Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-167551863
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-167551695
**[Test build #48364 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48364/consoleFull)**
for PR 10381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-167551862
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10381#discussion_r48472333
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -349,6 +352,41 @@ class ParamsSuite extends SparkFunSuite {
val t3
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10381#discussion_r48473237
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -349,6 +352,41 @@ class ParamsSuite extends SparkFunSuite {
val
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-167544609
**[Test build #48364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48364/consoleFull)**
for PR 10381 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10381
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-167648268
Thanks @srowen , @BenFradet and @yanboliang for the review. I'm merging
this into `master` and `branch-1.6`.
---
If your project is set up for it, you can reply to
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-167079541
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10381#discussion_r48412374
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -859,8 +859,12 @@ final class ParamMap private[ml] (private val map:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10381#discussion_r48410724
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -859,8 +859,12 @@ final class ParamMap private[ml] (private val map:
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-166247923
cc: @mengxr @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165813374
**[Test build #48008 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48008/consoleFull)**
for PR 10381 at commit
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10381#discussion_r48040453
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -859,8 +859,15 @@ final class ParamMap private[ml] (private val map:
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165817829
LGTM except one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10381#discussion_r48039929
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -859,8 +859,15 @@ final class ParamMap private[ml] (private val map:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165824760
**[Test build #48010 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48010/consoleFull)**
for PR 10381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165832374
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165831995
**[Test build #48008 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48008/consoleFull)**
for PR 10381 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10381#discussion_r48047813
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -859,8 +859,15 @@ final class ParamMap private[ml] (private val map:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165841854
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165841851
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165832376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165841573
**[Test build #48010 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48010/consoleFull)**
for PR 10381 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-16551
**[Test build #48019 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48019/consoleFull)**
for PR 10381 at commit
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/10381
[SPARK-12424][ML] The implementation of ParamMap#filter is wrong.
ParamMap#filter uses `mutable.Map#filterKeys`. The return type of
`filterKey` is collection.Map, not mutable.Map but the result is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165897493
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165897372
**[Test build #48019 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48019/consoleFull)**
for PR 10381 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10381#issuecomment-165897494
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
29 matches
Mail list logo
