Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-167656781
ML changes look good to me. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-167668145
@andrewor14 could you take a look at this pr? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10440#discussion_r48510554
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -386,9 +386,9 @@ private[tree] object LearningNode {
var levelsToGo =
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-167671951
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10440#discussion_r48510515
--- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java ---
@@ -151,7 +151,7 @@ private static String
prepareWindowsCommand(List cmd,
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-167672081
Maybe @yhuai or @liancheng should take a quick look at the SQL changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-167675193
sql changes look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-167675496
Thanks. Merging to master and 1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/10440
[SPARK-12489][Core][SQL][MLib]Fix minor issues found by FindBugs
Include the following changes:
1. Close `java.sql.Statement`
2. Fix incorrect `asInstanceOf`.
3. Remove unnecessary
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10440#discussion_r48302657
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -293,9 +293,7 @@ private String createSecret() {
protected
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-166766635
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-166766567
**[Test build #48215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48215/consoleFull)**
for PR 10440 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-166766636
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10440#issuecomment-166743479
**[Test build #48215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48215/consoleFull)**
for PR 10440 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10440#discussion_r48302836
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
---
@@ -122,30 +122,35 @@ private[sql] object JDBCRDD
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10440#discussion_r48302787
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -386,9 +386,9 @@ private[tree] object LearningNode {
var levelsToGo =
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10440#discussion_r48302701
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -126,7 +125,7 @@ private[spark] class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10440#discussion_r48302745
--- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java ---
@@ -151,7 +151,7 @@ private static String
prepareWindowsCommand(List cmd,
19 matches
Mail list logo
