[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167743790 **[Test build #48393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48393/consoleFull)** for PR 10501 at commit [`c6d6ba0`](https://g

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167743823 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167743822 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10501 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167718080 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167716481 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167716483 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167716360 **[Test build #48392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48392/consoleFull)** for PR 10501 at commit [`5157f27`](https://g

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167715541 **[Test build #48393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48393/consoleFull)** for PR 10501 at commit [`c6d6ba0`](https://gi

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167714800 Yea that's an interesting one -- although in some files we might actually want that and I don't know whether we can still disable it (maybe we can?). --- If your project

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167714726 Can we add a Scalastyle rule to match the shotgun-approach `scalastyle:off` directive? :smiley: --- If your project is set up for it, you can reply to this email an

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10501#issuecomment-167703839 **[Test build #48392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48392/consoleFull)** for PR 10501 at commit [`5157f27`](https://gi

[GitHub] spark pull request: [SPARK-12547][SQL] Tighten scala style checker...

2015-12-28 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/10501 [SPARK-12547][SQL] Tighten scala style checker enforcement for UDF registration We use scalastyle:off to turn off style checks in certain places where it is not possible to follow the style guide. Th