[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-14 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49776238 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystQlSuite.scala --- @@ -17,36 +17,157 @@ package

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49777022 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystQlSuite.scala --- @@ -17,36 +17,157 @@ package

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49524882 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/CatalystQlSuite.scala --- @@ -17,36 +17,157 @@ package

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170714313 **[Test build #49184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49184/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170742248 I'm going to merge this. @cloud-fan it would be great for you to still take a look post-hoc and @hvanhovell can address feedback in his next pull request. Thanks. ---

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170742128 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49386798 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala --- @@ -41,16 +47,9 @@ private[sql] class CatalystQl(val conf: ParserConf

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170710545 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170710543 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170741917 **[Test build #49184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49184/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170709769 @cloud-fan can you also take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170742130 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-11 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49374680 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala --- @@ -58,26 +57,39 @@ private[sql] class CatalystQl(val conf:

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169928634 **[Test build #49005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49005/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169928804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169928806 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170097654 **[Test build #49022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49022/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170070628 **[Test build #49022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49022/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170097979 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170097976 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169846366 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169846245 **[Test build #48983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48983/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169846362 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169838962 **[Test build #48983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48983/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169911391 **[Test build #49005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49005/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169797907 **[Test build #48965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48965/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/10649 [SPARK-12576][SQL] Enable expression parsing in CatalystQl The PR allows us to use the new SQL parser to parse SQL expressions such as: ```1 + sin(x*x)``` We enable this functionality

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169821476 **[Test build #48965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48965/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169821750 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169821749 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49128910 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala --- @@ -58,26 +51,35 @@ private[sql] class CatalystQl(val conf: ParserConf

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49125905 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala --- @@ -41,16 +41,9 @@ private[sql] class CatalystQl(val conf: ParserConf

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49128191 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala --- @@ -28,7 +28,15 @@ import

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49128237 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala --- @@ -28,7 +28,15 @@ import

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10649#discussion_r49128521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala --- @@ -58,26 +51,35 @@ private[sql] class CatalystQl(val conf: ParserConf