Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10606#discussion_r48922730
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -223,14 +227,9 @@ public void loadNext() {
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10606#issuecomment-169203949
@JoshRosen I'm merging this into master and 1.6 branch to unblock another
PR, will add @Nullable in that PR.
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10606
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10606#issuecomment-169204251
More comments would also be appreciated, since this is pretty confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/10606
[SPARK-12659] fix NPE in UnsafeExternalSorter (used by cartesian product)
Cartesian product use UnsafeExternalSorter without comparator to do
spilling, it will NPE if spilling happens.
cc
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10606#issuecomment-169160794
**[Test build #48793 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48793/consoleFull)**
for PR 10606 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10606#issuecomment-169187512
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10606#issuecomment-169187237
**[Test build #48793 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48793/consoleFull)**
for PR 10606 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10606#issuecomment-169187517
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10606#discussion_r48919509
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -223,14 +227,9 @@ public void loadNext() {
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10606#discussion_r48911600
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -99,7 +99,11 @@ public UnsafeInMemorySorter(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10606#discussion_r48911664
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -223,14 +227,9 @@ public void loadNext() {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10606#discussion_r48912881
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -223,14 +227,9 @@ public void loadNext() {
13 matches
Mail list logo
