Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-171115375
The rest are ok since they are small. I reverted the sql one because it was
large.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-171114404
```
1. In many cases for type bounds, ti is good to have a space before the
colon so it is more clear.
2. For type descriptions (e.g. variable : Int), it is also
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-171052858
@sarutak I actually reverted this change after talking more with Michael
and looking at the diffs. The problem is that for colon, in some cases it is
really useful to have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170792354
Thanks - I'm going to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170773423
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170773425
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170773257
**[Test build #49199 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49199/consoleFull)**
for PR 10685 at commit
[`0055761`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170755311
**[Test build #49199 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49199/consoleFull)**
for PR 10685 at commit
[`0055761`](https://gi
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170752454
I think the PySpark unit test failures above are related to #10704 and
already fixed.
---
If your project is set up for it, you can reply to this email and have your
r
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170752462
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170629449
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170629445
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170629202
**[Test build #49153 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49153/consoleFull)**
for PR 10685 at commit
[`0055761`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170599333
**[Test build #49153 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49153/consoleFull)**
for PR 10685 at commit
[`0055761`](https://gi
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170597277
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170582183
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170582188
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170581952
**[Test build #49144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49144/consoleFull)**
for PR 10685 at commit
[`0055761`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170551190
**[Test build #49144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49144/consoleFull)**
for PR 10685 at commit
[`0055761`](https://gi
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170550426
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170549645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170549636
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170549509
**[Test build #49138 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49138/consoleFull)**
for PR 10685 at commit
[`0055761`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170512729
**[Test build #49138 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49138/consoleFull)**
for PR 10685 at commit
[`0055761`](https://gi
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170510313
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170508690
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170508694
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170508451
**[Test build #49119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49119/consoleFull)**
for PR 10685 at commit
[`0055761`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170472214
**[Test build #49119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49119/consoleFull)**
for PR 10685 at commit
[`0055761`](https://gi
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170469632
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170422189
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170422188
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170422175
**[Test build #49085 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49085/consoleFull)**
for PR 10685 at commit
[`0055761`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170421364
**[Test build #49085 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49085/consoleFull)**
for PR 10685 at commit
[`0055761`](https://gi
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170419723
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170419332
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170419331
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170419302
**[Test build #49074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49074/consoleFull)**
for PR 10685 at commit
[`0055761`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170400058
**[Test build #49074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49074/consoleFull)**
for PR 10685 at commit
[`0055761`](https://gi
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170399749
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170399706
#10683 and #10678 may hit the same MiMa problem
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170399626
The reason of the MiMa failure is Maven Central doesn't provide
`mvttv3;1.0.1` while `streaming-mqtt_2.10;1.6.0` depends on mqttv3;1.0.1 right?
```
[info]
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170396472
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170396458
**[Test build #49072 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49072/consoleFull)**
for PR 10685 at commit
[`0055761`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170396474
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170395680
**[Test build #49072 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49072/consoleFull)**
for PR 10685 at commit
[`0055761`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170392942
**[Test build #49069 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49069/consoleFull)**
for PR 10685 at commit
[`708f934`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170392958
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170392957
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170392004
LGTM - the mima check is related to the logging trait change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170391954
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170391956
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170391939
**[Test build #49067 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49067/consoleFull)**
for PR 10685 at commit
[`4190930`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170391768
**[Test build #49069 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49069/consoleFull)**
for PR 10685 at commit
[`708f934`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170391729
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170391732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170389249
**[Test build #49067 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49067/consoleFull)**
for PR 10685 at commit
[`4190930`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170385704
**[Test build #49066 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49066/consoleFull)**
for PR 10685 at commit
[`39ef2b8`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170385707
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170385464
**[Test build #49066 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49066/consoleFull)**
for PR 10685 at commit
[`39ef2b8`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10685#issuecomment-170385710
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10685#discussion_r49280447
--- Diff:
external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/Logging.scala
---
@@ -26,20 +26,20 @@ import org.slf4j.{Logger, LoggerFac
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/10685
[SPARK-12692][BUILD][STREAMING] Scala style: Fix the style violation (Space
before "," or ":")
Fix the style violation (space before , and :).
This PR is a followup for #10643.
You can merge t
64 matches
Mail list logo
