Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10962
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183128117
Merged into master and branch-1.6. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183125205
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183125211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183124943
**[Test build #51152 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51152/consoleFull)**
for PR 10962 at commit
[`6581575`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183120615
**[Test build #51152 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51152/consoleFull)**
for PR 10962 at commit
[`6581575`](https://gi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183118677
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183118493
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183118490
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183112906
Thanks for reviewing @mengxr! I have addressed your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-183109271
@sethah The changes look good to me and thanks for fixing it! I would say
this is a bug and we should backport it to branch-1.6. So the note on the
behavior change is un
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10962#discussion_r52686031
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -156,9 +156,16 @@ def hasParam(self, paramName):
"""
Tests whether this instance
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180499905
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180499795
**[Test build #2521 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2521/consoleFull)**
for PR 10962 at commit
[`8dc7d05`](https://
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180499908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180499618
**[Test build #50826 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50826/consoleFull)**
for PR 10962 at commit
[`8dc7d05`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180494282
**[Test build #50826 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50826/consoleFull)**
for PR 10962 at commit
[`8dc7d05`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180494296
**[Test build #2521 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2521/consoleFull)**
for PR 10962 at commit
[`8dc7d05`](https://g
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180485241
@davies Thanks for taking a look! I have addressed your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180480810
LGTM, just one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10962#discussion_r52052341
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -156,9 +156,16 @@ def hasParam(self, paramName):
"""
Tests whether this instance
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-180478448
ping! @yanboliang @jkbradley
This is a small change that will allow the Python API to match the Scala
API, where the current behavior could be reasonably stated
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176439329
Maybe @davies or @jkbradley could take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176432631
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176432626
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176432322
**[Test build #50296 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50296/consoleFull)**
for PR 10962 at commit
[`a1b885c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176426837
**[Test build #50296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50296/consoleFull)**
for PR 10962 at commit
[`a1b885c`](https://gi
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10962#discussion_r51188359
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -156,9 +156,16 @@ def hasParam(self, paramName):
"""
Tests whether this instance
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176325696
Good point about mirroring Scala. In that case, it is probably best not to
change it.
---
If your project is set up for it, you can reply to this email and have your
re
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176323543
Looking at params.scala shouldOwn uses a require which we should probably
stay consistent with (not saying we _shouldn't_ change it per-se just if we do
we should chang
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176319087
I wonder if there is support for also changing `_shouldOwn` to return
True/False instead of True/ValueError? The only placed it is currently used is
in `_resolveParam`,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176278459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176278457
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176278153
**[Test build #50277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50277/consoleFull)**
for PR 10962 at commit
[`2989f93`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176269418
**[Test build #50277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50277/consoleFull)**
for PR 10962 at commit
[`2989f93`](https://gi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10962#discussion_r51087340
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -152,13 +152,17 @@ def isDefined(self, param):
return self.isSet(param) or self.hasDefaul
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10962#discussion_r51076979
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -152,13 +152,17 @@ def isDefined(self, param):
return self.isSet(param) or self.hasDefault(pa
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10962#discussion_r51075753
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -152,13 +152,17 @@ def isDefined(self, param):
return self.isSet(param) or self.hasDefaul
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-175921366
I think this makes sense since it is harmonizing the behaviour with the
Scala API. Perhaps adding a note in the PyDoc about the new behaviour as well
as a test might be
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-175920740
**[Test build #50242 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50242/consoleFull)**
for PR 10962 at commit
[`d52b1de`](https://gi
GitHub user sethah opened a pull request:
https://github.com/apache/spark/pull/10962
[SPARK-13047][PYSPARK][ML] Pyspark Params.hasParam should not throw an error
Pyspark Params class has a method `hasParam(paramName)` which returns
`True` if the class has a parameter by that name, b
41 matches
Mail list logo
