[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11663 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200476479 LGTM Thanks for a great PR! Merging with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200428484 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200428492 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200427992 **[Test build #53943 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53943/consoleFull)** for PR 11663 at commit [`3e55f83`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200421289 **[Test build #53943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53943/consoleFull)** for PR 11663 at commit [`3e55f83`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-23 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57189567 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +80,144 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-23 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57189492 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +80,144 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200072336 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200072337 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200072224 **[Test build #53835 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53835/consoleFull)** for PR 11663 at commit [`6a8d5f6`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200069161 I also commented on 1 earlier item (about the conversions to str) --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57084286 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +80,144 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57084301 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +80,144 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57083934 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200068226 **[Test build #53835 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53835/consoleFull)** for PR 11663 at commit [`6a8d5f6`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57083431 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -17,28 +17,38 @@ from abc import ABCMeta import copy +import numpy as np +import w

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200066688 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200066684 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200066395 **[Test build #53832 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53832/consoleFull)** for PR 11663 at commit [`2c46076`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57081986 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -17,28 +17,38 @@ from abc import ABCMeta import copy +import numpy as np +impor

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200062615 **[Test build #53832 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53832/consoleFull)** for PR 11663 at commit [`2c46076`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200052416 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200052418 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200052411 **[Test build #53827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53827/consoleFull)** for PR 11663 at commit [`99eed51`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200051224 **[Test build #53827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53827/consoleFull)** for PR 11663 at commit [`99eed51`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57077422 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +80,144 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200041490 **[Test build #53821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53821/consoleFull)** for PR 11663 at commit [`e1e4643`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200041499 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200041505 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200040354 **[Test build #53821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53821/consoleFull)** for PR 11663 at commit [`e1e4643`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200027312 **[Test build #53816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53816/consoleFull)** for PR 11663 at commit [`ff7f94d`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200027327 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200027324 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57068522 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -275,23 +425,9 @@ def _set(self, **kwargs): """ for param, value in kwargs.items

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-200024545 **[Test build #53816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53816/consoleFull)** for PR 11663 at commit [`ff7f94d`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57068396 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57068235 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57068173 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -17,28 +17,38 @@ from abc import ABCMeta import copy +import numpy as np +import w

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024858 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-199906155 I made another pass. I only had minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024837 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024870 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -275,23 +425,9 @@ def _set(self, **kwargs): """ for param, value in kwargs.it

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024815 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024739 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024854 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024786 --- Diff: python/pyspark/ml/feature.py --- @@ -441,7 +445,8 @@ class ElementwiseProduct(JavaTransformer, HasInputCol, HasOutputCol, MLReadable, ""

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024800 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -17,28 +17,38 @@ from abc import ABCMeta import copy +import numpy as np +impor

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024806 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -17,28 +17,38 @@ from abc import ABCMeta import copy +import numpy as np +impor

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024828 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024850 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024848 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +75,146 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-22 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r57024794 --- Diff: python/pyspark/ml/feature.py --- @@ -2502,7 +2524,7 @@ def __init__(self, numTopFeatures=50, featuresCol="features", outputCol=None, la

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-199431275 **[Test build #2654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2654/consoleFull)** for PR 11663 at commit [`c483da8`](https://

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-199424805 **[Test build #2654 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2654/consoleFull)** for PR 11663 at commit [`c483da8`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-20 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406675 --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py --- @@ -105,64 +104,71 @@ def get$Name(self): if __name__ == "__main__": print(he

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-20 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-197527954 Made an initial pass. I like this update--thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56548501 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-20 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406653 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-20 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56547314 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406664 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -275,23 +382,9 @@ def _set(self, **kwargs): """ for param, value in kwargs.it

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406609 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -32,13 +35,17 @@ class Param(object): .. versionadded:: 1.3.0 """ -def

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56548536 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56548612 --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py --- @@ -105,64 +104,71 @@ def get$Name(self): if __name__ == "__main__": print(heade

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406626 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406644 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-197997430 **[Test build #53438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53438/consoleFull)** for PR 11663 at commit [`c483da8`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-197997448 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread sethah
Github user sethah commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-198008868 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-198009920 **[Test build #53446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53446/consoleFull)** for PR 11663 at commit [`c483da8`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56547627 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-197994412 **[Test build #53438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53438/consoleFull)** for PR 11663 at commit [`c483da8`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406681 --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py --- @@ -105,64 +104,71 @@ def get$Name(self): if __name__ == "__main__": print(he

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-198012665 **[Test build #53446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53446/consoleFull)** for PR 11663 at commit [`c483da8`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406655 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406647 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-198012696 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406671 --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py --- @@ -105,64 +104,71 @@ def get$Name(self): if __name__ == "__main__": print(he

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406616 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56548734 --- Diff: python/pyspark/ml/param/_shared_params_code_gen.py --- @@ -105,64 +104,71 @@ def get$Name(self): if __name__ == "__main__": print(heade

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56547567 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-198012705 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56547465 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConvert

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-18 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11663#discussion_r56406633 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -65,6 +72,106 @@ def __eq__(self, other): return False +class TypeConv

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-197997442 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-196399775 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-196399772 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-196399588 **[Test build #53077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53077/consoleFull)** for PR 11663 at commit [`40b00dd`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-196388562 **[Test build #53077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53077/consoleFull)** for PR 11663 at commit [`40b00dd`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-196383174 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-196383179 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-196383071 **[Test build #53076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53076/consoleFull)** for PR 11663 at commit [`34e9925`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-196374260 **[Test build #53076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53076/consoleFull)** for PR 11663 at commit [`34e9925`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-195603471 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-195603467 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-195603328 **[Test build #52960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52960/consoleFull)** for PR 11663 at commit [`40b00dd`](https://g

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11663#issuecomment-195599201 **[Test build #52960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52960/consoleFull)** for PR 11663 at commit [`40b00dd`](https://gi

[GitHub] spark pull request: [SPARK-13068][PYSPARK][ML] Type conversion for...

2016-03-11 Thread sethah
GitHub user sethah opened a pull request: https://github.com/apache/spark/pull/11663 [SPARK-13068][PYSPARK][ML] Type conversion for Pyspark params ## What changes were proposed in this pull request? This patch adds type conversion functionality for parameters in Pyspark. A