Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11293#discussion_r53671961
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveCatalog.scala ---
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Founda
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11293#discussion_r53585835
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveCatalog.scala ---
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186995812
I didn't review the core parts of this PR yet, hopefully @rxin had done
that.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186944373
> because we might have many "tables".
Yeah that's why I renamed it in the first place. As of this patch though
there are no more classes that are called jus
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186940230
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186940231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186940162
**[Test build #51644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51644/consoleFull)**
for PR 11293 at commit
[`6703aa5`](https://g
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186939416
Going to merge this in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186939374
Alright let's discuss the renaming. I initially just used Table, but I
think both could work (Table or CatalogTable), because we might have many
"tables".
---
If your p
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186938837
**[Test build #2559 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2559/consoleFull)**
for PR 11293 at commit
[`6703aa5`](https://
Github user andrewor14 closed the pull request at:
https://github.com/apache/spark/pull/11189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186930674
Closing in favor of #11293.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186930661
Thanks, @davies also suggested offline to rename all `CatalogTable` and
related classes to just `Table`. We can do that separately after this patch
gets merged.
--
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186918335
**[Test build #51644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51644/consoleFull)**
for PR 11293 at commit
[`6703aa5`](https://gi
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186915642
LGTM pending tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186914838
**[Test build #2559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2559/consoleFull)**
for PR 11293 at commit
[`6703aa5`](https://g
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11293#issuecomment-186914774
I simply brought https://github.com/apache/spark/pull/11189 up to date and
resolved some code review issues so we can merge this quickly and unblock some
other work.
--
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186914590
FYI I took most of Herman and Davies' comments and created a rebased pr
here: https://github.com/apache/spark/pull/11293
---
If your project is set up for it, you c
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/11293
[SPARK-13080] [SQL] Implement new Catalog API using Hive
## What changes were proposed in this pull request?
This is a step towards merging `SQLContext` and `HiveContext`. A new
internal Cata
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186908709
@andrewor14 This is pretty solid, couldn't find anything except for some
trivial stuff.
LGTM pending an update to the latest master and a succesfull test run
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r53572493
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -18,24 +18,26 @@
package org.apache.spark.sql.hive.cl
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r53572447
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -765,9 +771,14 @@ private[hive] case class MetastoreRelation
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r53572202
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -174,40 +207,65 @@ case class TablePartition(
*
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r53509299
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -244,30 +243,42 @@ class InMemoryCatalog extends Cat
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r53508051
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -47,39 +48,33 @@ class InMemoryCatalog extends Catal
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r53507668
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -30,15 +30,16 @@ import org.apache.spark.sql.Analysi
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r53507403
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the A
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186370128
I'll have a look this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186329269
No, just waiting for review at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186041941
I took a quick look and this looks reasonable. The changes were
straightforward.
@andrewor14 are there still minor things you need to do here?
---
If your proje
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186041768
@hvanhovell would you have time to review some of this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186041567
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186041568
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186041433
**[Test build #51509 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51509/consoleFull)**
for PR 11189 at commit
[`d9a7723`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186010618
**[Test build #51509 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51509/consoleFull)**
for PR 11189 at commit
[`d9a7723`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186005966
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186005964
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186005938
**[Test build #51507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51507/consoleFull)**
for PR 11189 at commit
[`2ba1990`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-186001752
**[Test build #51507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51507/consoleFull)**
for PR 11189 at commit
[`2ba1990`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185576335
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185576337
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185576121
**[Test build #51469 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51469/consoleFull)**
for PR 11189 at commit
[`428c3c5`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185547689
**[Test build #51469 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51469/consoleFull)**
for PR 11189 at commit
[`428c3c5`](https://gi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185543982
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185526159
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185526160
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185523231
Alright, as of the latest commit this patch is no longer WIP. I added a
test suite for the new `HiveCatalog` and all but one test in that suite are now
passing. The
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11189#issuecomment-185523240
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
49 matches
Mail list logo
