[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-19 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-197623653 For some reason, this PR breaks the following invocation: ``` ./dev/make-distribution.sh -T 1C -Phadoop-2.6 ``` The problem appears to be with

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-19 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-198476804 Looking at the debug output by Maven, it looks like there were some project structure changes that interfere with Maven's ability to do parallel builds. See:

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-11 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195323566 @JoshRosen MiMA check is re-enabled in PR #11656. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195228278 I've rolled back a bunch of changes and minimized this patch to a point where I think it's safe and uncontroversial, so I'm going to merge this into master now so

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195224384 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195224378 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195224015 **[Test build #52891 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52891/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195214938 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195214934 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195214185 **[Test build #52893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52893/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195212398 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195212397 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195212238 **[Test build #52896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52896/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195168191 **[Test build #52896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52896/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195167517 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195167518 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195167353 **[Test build #52882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52882/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195166385 **[Test build #52893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52893/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195166234 Alright, MiMa passes, so I've gone ahead and merged with master to pull in the change to temporarily disable MiMa during the DF -> DS[Row] type aliasing / migration.

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195161393 **[Test build #52891 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52891/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195161052 As it turns out I think we do need to pull in transitive deps of the old spark version given that we're no longer getting transitive deps from the new spark version

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195159014 Modified the code to give more detail in the error message: ``` Error instrumenting class:org.apache.spark.deploy.history.HistoryServer$

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195157817 ``` [error] * deprecated method mapPartitionsWithContext(scala.Function2,Boolean,scala.reflect.ClassTag)org.apache.spark.rdd.RDD in class

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195157575 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195157478 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195157479 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195157470 **[Test build #52880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52880/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195157574 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195157466 **[Test build #52887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52887/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195153842 **[Test build #52887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52887/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195153273 Reverted improvements, so the diff should be tiny. I'll now be able to confirm that the generated excludes match exactly. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195152649 Actually, maybe I can roll back the changes to the exclude generation which were aimed at reducing log noise; those can go in separately and slitting them off will

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11178#discussion_r55782966 --- Diff: tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala --- @@ -80,20 +79,25 @@ object GenerateMIMAIgnore { /* Inner

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11178#discussion_r55782566 --- Diff: tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala --- @@ -160,35 +167,13 @@ object GenerateMIMAIgnore { * and

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11178#discussion_r55782542 --- Diff: tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala --- @@ -133,14 +140,14 @@ object GenerateMIMAIgnore { val

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/11178#discussion_r55782510 --- Diff: tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala --- @@ -105,16 +109,19 @@ object GenerateMIMAIgnore { /**

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195149465 Okay, this is now ready for review. I've re-scoped this patch to only focus on removing the need to build an assembly before running `dev/mima` and removed all

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195131126 **[Test build #52882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52882/consoleFull)** for PR 11178 at commit

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Remove MiMa's de...

2016-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-195127050 **[Test build #52880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52880/consoleFull)** for PR 11178 at commit