[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11890 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11486 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11890#issuecomment-200033982 Thanks! Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/11890#issuecomment-200023253 @mengxr it looks great, I have no comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11890#issuecomment-199947947 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11890#issuecomment-199947949 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11890#issuecomment-199947714 **[Test build #53787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53787/consoleFull)** for PR 11890 at commit [`0ac224e`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11890#issuecomment-199923314 **[Test build #53787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53787/consoleFull)** for PR 11890 at commit [`0ac224e`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-22 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-199887454 @yinxusen I checked the implementation in e1071 and found that it supports both categorical and continuous features, which in MLlib we only support categorical features.

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198877947 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198877946 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198877928 **[Test build #53629 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53629/consoleFull)** for PR 11486 at commit [`3d291de`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198876260 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198876238 **[Test build #53627 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53627/consoleFull)** for PR 11486 at commit [`87fa0aa`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198876261 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198871790 **[Test build #53629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53629/consoleFull)** for PR 11486 at commit [`3d291de`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198870531 @mengxr @yanboliang Since the `ml.NaiveBayes` making the assumption that its input data's label is 0-based indices, we should add a `StringIndexer` for labels after `R

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198870226 **[Test build #53627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53627/consoleFull)** for PR 11486 at commit [`87fa0aa`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-20 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56760149 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala --- @@ -248,6 +248,18 @@ class RFormulaModel private[feature]( !columnN

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198845476 **[Test build #53622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53622/consoleFull)** for PR 11486 at commit [`b4ee1aa`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198845488 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198845487 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-198841429 **[Test build #53622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53622/consoleFull)** for PR 11486 at commit [`b4ee1aa`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197661336 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197676388 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56430750 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -141,3 +141,26 @@ test_that("kmeans", { cluster <- summary.model$cluster expect_equal(s

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197665613 **[Test build #53387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53387/consoleFull)** for PR 11486 at commit [`90b6ad9`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56619866 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala --- @@ -248,6 +248,18 @@ class RFormulaModel private[feature]( !colum

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197676145 **[Test build #53387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53387/consoleFull)** for PR 11486 at commit [`90b6ad9`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197676398 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-19 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56447514 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala --- @@ -227,6 +233,35 @@ class NaiveBayesModel private[ml] (

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56623549 --- Diff: R/pkg/R/mllib.R --- @@ -71,14 +71,23 @@ setMethod("glm", signature(formula = "formula", family = "ANY", data = "DataFram #' @rdname predic

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197661337 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197661334 **[Test build #53386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53386/consoleFull)** for PR 11486 at commit [`8e21393`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197659555 **[Test build #53386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53386/consoleFull)** for PR 11486 at commit [`8e21393`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197193976 @mengxr One more thing, could you take a look at https://issues.apache.org/jira/browse/SPARK-13641? If we extract feature names from the RFormulaModel transformed data

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197192991 I'll try to extract raw labels. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56290378 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -141,3 +141,26 @@ test_that("kmeans", { cluster <- summary.model$cluster expect_equal(s

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56290215 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -141,3 +141,26 @@ test_that("kmeans", { cluster <- summary.model$cluster expect_equal(sor

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-197191433 About labels, I think we should output the raw labels as predictions instead of the encoded indices. It is hard to extract the feature metadata in SparkR. --- If your

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56290089 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -141,3 +141,26 @@ test_that("kmeans", { cluster <- summary.model$cluster expect_equal(s

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56289859 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala --- @@ -227,6 +236,25 @@ class NaiveBayesModel private[ml] ( @

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56289848 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -141,3 +141,26 @@ test_that("kmeans", { cluster <- summary.model$cluster expect_equal(sor

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56289840 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -141,3 +141,26 @@ test_that("kmeans", { cluster <- summary.model$cluster expect_equal(sor

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56289845 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -141,3 +141,26 @@ test_that("kmeans", { cluster <- summary.model$cluster expect_equal(sor

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-16 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56289853 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -141,3 +141,26 @@ test_that("kmeans", { cluster <- summary.model$cluster expect_equal(sor

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-15 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56265257 --- Diff: R/pkg/R/generics.R --- @@ -1168,3 +1168,7 @@ setGeneric("kmeans") #' @rdname fitted #' @export setGeneric("fitted") + +#' @r

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r56258707 --- Diff: R/pkg/R/generics.R --- @@ -1168,3 +1168,7 @@ setGeneric("kmeans") #' @rdname fitted #' @export setGeneric("fitted") + +#' @rdn

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-195864128 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-195864131 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-195863942 **[Test build #53019 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53019/consoleFull)** for PR 11486 at commit [`9991e79`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-195861369 **[Test build #53019 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53019/consoleFull)** for PR 11486 at commit [`9991e79`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194621830 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194621836 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194621148 **[Test build #52799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52799/consoleFull)** for PR 11486 at commit [`dbaf4e6`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-09 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r55621785 --- Diff: R/pkg/R/mllib.R --- @@ -192,3 +210,37 @@ setMethod("fitted", signature(object = "PipelineModel"), stop(paste("Unsupported model

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194604495 **[Test build #52799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52799/consoleFull)** for PR 11486 at commit [`dbaf4e6`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-09 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194604372 @felixcheung Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194125311 From SparkR test failure: ``` 1. Error: naiveBayes --- there is no package called 'mlbench' 1

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r55474419 --- Diff: R/pkg/R/mllib.R --- @@ -192,3 +210,37 @@ setMethod("fitted", signature(object = "PipelineModel"), stop(paste("Unsupported mo

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r55474361 --- Diff: R/pkg/R/generics.R --- @@ -1168,3 +1168,7 @@ setGeneric("kmeans") #' @rdname fitted #' @export setGeneric("fitted") + +#'

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r55474302 --- Diff: R/pkg/R/mllib.R --- @@ -192,3 +210,37 @@ setMethod("fitted", signature(object = "PipelineModel"), stop(paste("Unsupported mo

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r55474272 --- Diff: R/pkg/R/mllib.R --- @@ -192,3 +210,37 @@ setMethod("fitted", signature(object = "PipelineModel"), stop(paste("Unsupported mo

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11486#discussion_r55474264 --- Diff: R/pkg/R/mllib.R --- @@ -192,3 +210,37 @@ setMethod("fitted", signature(object = "PipelineModel"), stop(paste("Unsupported mo

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194117566 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194117569 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194117451 **[Test build #52723 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52723/consoleFull)** for PR 11486 at commit [`30e9c37`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194111388 **[Test build #52723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52723/consoleFull)** for PR 11486 at commit [`30e9c37`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194058243 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194058224 **[Test build #52713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52713/consoleFull)** for PR 11486 at commit [`1a685e1`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194058244 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194055694 **[Test build #52713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52713/consoleFull)** for PR 11486 at commit [`1a685e1`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-08 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-194054855 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-07 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-193391568 retest it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-07 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-193390578 @yanboliang @jkbradley For this PR, I extract labels manually from labelCol. But I still don't think it's good to make assumption first for labels to be 0-bas

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-193388779 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-193388758 **[Test build #52574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52574/consoleFull)** for PR 11486 at commit [`1a685e1`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-193388773 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-193386606 **[Test build #52574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52574/consoleFull)** for PR 11486 at commit [`1a685e1`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-04 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-192527483 I think it works. I'll try to add it later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-03 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-192089154 It's a good question! It's possible that the label of input dataset is not 0 based or not continuous. So we should use ```StringIndexer``` to index label in [0, numL

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-03 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191814257 I can see from the mllib.NaiveBayes that the labels are sorted. But how about if it is not 0 based or not continuous? Say, `1.0, 3.0, 5.0, ...`. It has no effect on tr

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-03 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191694969 Labels of ML ```NaiveBayesModel``` are sorted(FYI #7284), so we do not need to store it as member variable. Then it can pass the binary compatibility check. --- If

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191633388 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191633391 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191633301 **[Test build #52382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52382/consoleFull)** for PR 11486 at commit [`a07beb2`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191624904 **[Test build #52382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52382/consoleFull)** for PR 11486 at commit [`a07beb2`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191601008 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191601001 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191600863 **[Test build #52376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52376/consoleFull)** for PR 11486 at commit [`26d38e1`](https://g

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191597928 **[Test build #52376 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52376/consoleFull)** for PR 11486 at commit [`26d38e1`](https://gi

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11486#issuecomment-191597396 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-13449] Naive Bayes wrapper in SparkR

2016-03-02 Thread yinxusen
GitHub user yinxusen opened a pull request: https://github.com/apache/spark/pull/11486 [SPARK-13449] Naive Bayes wrapper in SparkR ## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/SPARK-13449 Add a Naive Bayes wrapper in Spar