GitHub user s-urbaniak opened a pull request:
https://github.com/apache/spark/pull/11369
[SPARK-13492][MESOS] Configurable Mesos framework webui URL.
## What changes were proposed in this pull request?
Previously the Mesos framework webui URL was being derived only from the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-188782498
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54128358
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -95,6 +100,9 @@ private[mesos] class
MesosCluster
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54128676
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackendSuite.scala
---
@@ -84,10 +84,39 @@ class CoarseMesosSche
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189067330
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189069312
**[Test build #52011 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52011/consoleFull)**
for PR 11369 at commit
[`e6dedd5`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189070575
**[Test build #52011 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52011/consoleFull)**
for PR 11369 at commit
[`e6dedd5`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189070589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189070584
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189259910
**[Test build #52050 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52050/consoleFull)**
for PR 11369 at commit
[`586d6de`](https://gi
Github user s-urbaniak commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54248150
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -95,6 +100,9 @@ private[mesos] class
MesosClust
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189307625
**[Test build #52050 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52050/consoleFull)**
for PR 11369 at commit
[`586d6de`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189308184
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189308179
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189328254
**[Test build #52054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52054/consoleFull)**
for PR 11369 at commit
[`e105b1c`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189329965
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189329954
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189329940
**[Test build #52054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52054/consoleFull)**
for PR 11369 at commit
[`e105b1c`](https://g
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54273607
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -95,6 +100,9 @@ private[mesos] class
MesosClusterDi
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54278192
--- Diff: docs/running-on-mesos.md ---
@@ -390,6 +390,22 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189414154
@s-urbaniak You need to fix the scala style error:
/home/jenkins/workspace/SparkPullRequestBuilder/core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/Coars
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189430613
**[Test build #52067 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52067/consoleFull)**
for PR 11369 at commit
[`3acdf74`](https://gi
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54295354
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -95,6 +100,9 @@ private[mesos] class
MesosCluster
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54295641
--- Diff: docs/running-on-mesos.md ---
@@ -390,6 +390,22 @@ See the [configuration page](configuration.html) for
information on Spark config
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189490761
**[Test build #52067 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52067/consoleFull)**
for PR 11369 at commit
[`3acdf74`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189491086
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-189491089
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user s-urbaniak commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54379487
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -95,6 +100,9 @@ private[mesos] class
MesosClust
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190091686
**[Test build #52181 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52181/consoleFull)**
for PR 11369 at commit
[`42f46dd`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190142413
**[Test build #52184 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52184/consoleFull)**
for PR 11369 at commit
[`fa8570d`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190144513
**[Test build #52181 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52181/consoleFull)**
for PR 11369 at commit
[`42f46dd`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190144865
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190144870
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190195908
**[Test build #52184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52184/consoleFull)**
for PR 11369 at commit
[`fa8570d`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190196225
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190196223
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54610842
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -44,7 +44,7 @@ private[mesos] class
MesosClusterDi
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54610723
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js
---
@@ -135,7 +135,7 @@ $(document).ready(function() {
}
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54657202
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js
---
@@ -135,7 +135,7 @@ $(document).ready(function() {
}
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-190973374
@s-urbaniak I think we should keep the existing -p since users might
actually depend on it. Otherwise this patch LGTM. @dragos you want to take a
look?
---
If your pr
Github user s-urbaniak commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54683231
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -44,7 +44,7 @@ private[mesos] class
MesosCluste
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/11369#discussion_r54859540
--- Diff:
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
---
@@ -44,7 +44,7 @@ private[mesos] class
MesosClusterDis
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-191692543
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-193372121
@andrewor14 this LGTM to me and @dragos , can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-194190167
**[Test build #52742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52742/consoleFull)**
for PR 11369 at commit
[`46ea0ab`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-194241030
**[Test build #52742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52742/consoleFull)**
for PR 11369 at commit
[`46ea0ab`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-194241335
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-194241338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11369#issuecomment-194619257
Merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
50 matches
Mail list logo
