Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11538
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-194304086
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-194102204
LGTM cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-194097264
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-194097268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-194097066
**[Test build #52712 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52712/consoleFull)**
for PR 11538 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-194055695
**[Test build #52712 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52712/consoleFull)**
for PR 11538 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193801813
LGTM except one style comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11538#discussion_r55364079
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveQlSuite.scala ---
@@ -208,4 +208,22 @@ class HiveQlSuite extends SparkFunSuite with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193771026
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193771034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193770318
**[Test build #52660 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52660/consoleFull)**
for PR 11538 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193730128
**[Test build #52660 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52660/consoleFull)**
for PR 11538 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193708141
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193708134
**[Test build #52655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52655/consoleFull)**
for PR 11538 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193708146
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193707287
**[Test build #52655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52655/consoleFull)**
for PR 11538 at commit
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193669285
Hi @cloud-fan Sure.. will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-193667899
hi @dilipbiswal , can you update your test case to use escaped back-ticks?
I think it's already handled by ANTLR.
---
If your project is set up for it, you can
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192755762
@liancheng Thanks a lot. I will work on the follow up PR to handle escaped
back-ticks.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192640189
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192640190
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192639952
**[Test build #52516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52516/consoleFull)**
for PR 11538 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192623039
This change itself LGTM. However, the current implementation of
`cleanIdentifier` doesn't handle escaped back-ticks within identifier names,
e.g. ``` `weird``name`
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192623148
**[Test build #52516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52516/consoleFull)**
for PR 11538 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192622938
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192616600
cc @liancheng @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192615259
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/11538
[SPARK-13698][SQL] Fix Analysis Exceptions when Using Backticks in Generate
## What changes were proposed in this pull request?
Analysis exception occurs while running the following query.
29 matches
Mail list logo
