Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56539712
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -549,7 +548,9 @@ trait Params extends Identifiable with Serializable {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197558359
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418460
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -117,7 +124,8 @@ class GeneralizedLinearRegression
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418502
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -159,7 +171,8 @@ class GeneralizedLinearRegression
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418533
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -538,7 +555,8 @@ object
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197618725
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56513463
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -549,7 +548,9 @@ trait Params extends Identifiable with Serializable {
*
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11620
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197558093
**[Test build #53347 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53347/consoleFull)**
for PR 11620 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197601316
**[Test build #53375 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53375/consoleFull)**
for PR 11620 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418508
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -169,7 +182,8 @@ class GeneralizedLinearRegression
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418523
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -322,7 +337,8 @@ object
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197621807
No problem. Thanks for the PR!
LGTM
Merging with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418455
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -61,7 +63,8 @@ private[regression] trait
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418480
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -133,7 +142,8 @@ class GeneralizedLinearRegression
Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197599295
@jkbradley Sorry for those unintentional changes and thanks for the
patience.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197618561
**[Test build #53375 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53375/consoleFull)**
for PR 11620 at commit
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56545500
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -549,7 +548,9 @@ trait Params extends Identifiable with Serializable {
*
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197558360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418486
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -141,7 +151,8 @@ class GeneralizedLinearRegression
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418536
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -556,7 +574,8 @@ object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197539250
**[Test build #53347 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53347/consoleFull)**
for PR 11620 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418469
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -125,7 +133,8 @@ class GeneralizedLinearRegression
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418529
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -359,7 +375,8 @@ object
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197618730
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418520
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -178,7 +192,8 @@ class GeneralizedLinearRegression
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-197556658
Thanks for the updates. Still some indentation issues, but that's it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56418491
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -150,7 +161,8 @@ class GeneralizedLinearRegression
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56553993
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -549,7 +548,9 @@ trait Params extends Identifiable with Serializable {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56256687
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -45,7 +46,8 @@ private[regression] trait
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56191807
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -45,7 +46,8 @@ private[regression] trait
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56105354
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -45,7 +46,8 @@ private[regression] trait
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-196606816
Only a few small comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56105350
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -549,7 +548,9 @@ trait Params extends Identifiable with Serializable {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11620#discussion_r56105356
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -77,7 +80,9 @@ private[regression] trait
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194993483
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194993480
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194993249
**[Test build #52833 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52833/consoleFull)**
for PR 11620 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194975722
**[Test build #52833 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52833/consoleFull)**
for PR 11620 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194733626
**[Test build #52822 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52822/consoleFull)**
for PR 11620 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194733637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194733636
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194733082
**[Test build #52822 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52822/consoleFull)**
for PR 11620 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194590012
**[Test build #52781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52781/consoleFull)**
for PR 11620 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194590058
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194590056
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11620#issuecomment-194579590
**[Test build #52781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52781/consoleFull)**
for PR 11620 at commit
GitHub user hhbyyh opened a pull request:
https://github.com/apache/spark/pull/11620
[SPARK-13761] [ML] Deprecate validateParams
## What changes were proposed in this pull request?
Deprecate validateParams() method here:
48 matches
Mail list logo
