Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r57043148
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -693,23 +693,25 @@ class MetastoreDataSourcesSuite
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r57038585
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -693,23 +693,25 @@ class MetastoreDataSourcesSuite extends
Github user skambha commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-199904383
Thanks @liancheng for the review, merging the fix and adding me to the
spark contributor group in Apache JIRA.
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-199794905
@skambha Nvm, found your account. It was just not in the Spark contributor
group. Added.
---
If your project is set up for it, you can reply to this email and have
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-199792869
@skambha Do you have a Apache JIRA account? Could you please register an
account if you don't so that I can assign this JIRA ticket to you? Thanks!
---
If your
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-199791507
LGTM. Merging to master. Thanks for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56978387
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -205,7 +205,16 @@ case class DataSource(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56978205
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -205,7 +205,16 @@ case class DataSource(
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-197785853
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-197787129
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-197787132
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
GitHub user skambha opened a pull request:
https://github.com/apache/spark/pull/11775
[SPARK-13774][SQL] - Improve error message for non-existent paths and add
tests
SPARK-13774: IllegalArgumentException: Can not create a Path from an empty
string for incorrect file path
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56474974
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -237,6 +237,8 @@ class SparkHadoopUtil extends Logging {
}
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56549702
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -237,6 +237,8 @@ class SparkHadoopUtil extends Logging {
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56634206
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -205,7 +205,16 @@ case class DataSource(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-197786613
**[Test build #53414 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53414/consoleFull)**
for PR 11775 at commit
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56689434
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -205,7 +205,16 @@ case class DataSource(
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-198196289
cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56475177
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -205,7 +205,17 @@ case class DataSource(
Github user skambha commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-198001758
@srowen Thanks for your comments. I have addressed them in the last
commit.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user skambha commented on a diff in the pull request:
https://github.com/apache/spark/pull/11775#discussion_r56551299
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -205,7 +205,17 @@ case class DataSource(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-197787115
**[Test build #53414 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53414/consoleFull)**
for PR 11775 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11775#issuecomment-197622078
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
24 matches
Mail list logo