[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-20 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56421080 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -167,7 +170,7 @@ abstract class ExternalCatalog { * @

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197596708 **[Test build #2647 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2647/consoleFull)** for PR 11750 at commit [`ad43a5f`](https://g

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56422492 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -211,8 +214,7 @@ case class CatalogTablePartition( *

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197620375 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56437475 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56424506 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197586553 If there are no major problems, let's merge this as soon as tests pass. We can address minor comments as followups. This will unblock a bunch of other stuff. --- If you

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197625591 **[Test build #2647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2647/consoleFull)** for PR 11750 at commit [`ad43a5f`](https://

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11750 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197586729 Yea, let's merge this once it passes tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197627234 OK. Let me merge this. Let's address comments in the follow-up pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56437967 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56436672 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197625831 **[Test build #2646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2646/consoleFull)** for PR 11750 at commit [`ad43a5f`](https://

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56386952 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,484 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197596742 **[Test build #2648 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2648/consoleFull)** for PR 11750 at commit [`ad43a5f`](https://g

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56437018 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197620171 **[Test build #53358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53358/consoleFull)** for PR 11750 at commit [`ad43a5f`](https://g

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197558997 **[Test build #53358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53358/consoleFull)** for PR 11750 at commit [`ad43a5f`](https://gi

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56442105 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56441976 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56394213 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,484 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197596671 **[Test build #2646 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2646/consoleFull)** for PR 11750 at commit [`ad43a5f`](https://g

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56425133 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -211,8 +214,7 @@ case class CatalogTablePartition(

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-18 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56442370 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-18 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56393684 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,484 @@ +/* + * Licensed to the Ap

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197620377 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-18 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56436908 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-18 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56424468 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,469 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197625780 **[Test build #2648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2648/consoleFull)** for PR 11750 at commit [`ad43a5f`](https://

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197131127 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197131125 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197131108 **[Test build #53263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53263/consoleFull)** for PR 11750 at commit [`3b2e48a`](https://g

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11750#discussion_r56276611 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -0,0 +1,484 @@ +/* + * Licensed to the Apache S

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-15 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197127331 @yhuai @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-13923] [SQL] Implement SessionCatalog

2016-03-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11750#issuecomment-197127120 **[Test build #53263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53263/consoleFull)** for PR 11750 at commit [`3b2e48a`](https://gi