[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12071 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-204008123 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203991308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203991305 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203990967 **[Test build #54624 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54624/consoleFull)** for PR 12071 at commit [`0a6528e`](https://g

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203943458 **[Test build #54624 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54624/consoleFull)** for PR 12071 at commit [`0a6528e`](https://gi

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203926187 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203926193 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203925310 **[Test build #54619 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54619/consoleFull)** for PR 12071 at commit [`2a93f3d`](https://g

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203882271 **[Test build #54619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54619/consoleFull)** for PR 12071 at commit [`2a93f3d`](https://gi

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203881788 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203879454 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203879452 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203879291 **[Test build #54610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54610/consoleFull)** for PR 12071 at commit [`2a93f3d`](https://g

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203839495 **[Test build #54610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54610/consoleFull)** for PR 12071 at commit [`2a93f3d`](https://gi

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203691190 **[Test build #2713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2713/consoleFull)** for PR 12071 at commit [`a3f1d79`](https://

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203663704 **[Test build #2713 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2713/consoleFull)** for PR 12071 at commit [`a3f1d79`](https://g

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12071#discussion_r57972363 --- Diff: dev/deps/spark-deps-hadoop-2.2 --- @@ -2,7 +2,8 @@ JavaEWAH-0.3.2.jar RoaringBitmap-0.5.11.jar ST4-4.0.4.jar activation-1.1.jar

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203658620 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203658616 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203658550 **[Test build #54550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54550/consoleFull)** for PR 12071 at commit [`a3f1d79`](https://g

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12071#discussion_r57971404 --- Diff: dev/deps/spark-deps-hadoop-2.2 --- @@ -2,7 +2,8 @@ JavaEWAH-0.3.2.jar RoaringBitmap-0.5.11.jar ST4-4.0.4.jar activation-1.1.jar -ant

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12071#discussion_r57971100 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -1,749 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12071#discussion_r57969727 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -1,749 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12071#discussion_r5794 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -54,7 +54,7 @@ statement (TBLPROPERTIES tablePr

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12071#discussion_r57965988 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -54,7 +54,7 @@ statement (TBLPROPERTIES tablePr

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203640538 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12071#discussion_r57965400 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -54,7 +54,7 @@ statement (TBLPROPERTIES tablePr

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12071#issuecomment-203633909 **[Test build #54550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54550/consoleFull)** for PR 12071 at commit [`a3f1d79`](https://gi

[GitHub] spark pull request: [SPARK-14211][SQL] Remove ANTLR3 based parser

2016-03-30 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/12071 [SPARK-14211][SQL] Remove ANTLR3 based parser ### What changes were proposed in this pull request? This PR removes the ANTLR3 based parser, and moves the new ANTLR4 based parser into th