[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-207894445 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-207409595 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-207409586 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-207409437 **[Test build #55342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55342/consoleFull)** for PR 12143 at commit

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-207402589 **[Test build #55342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55342/consoleFull)** for PR 12143 at commit

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-207400756 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-07 Thread yongtang
Github user yongtang commented on a diff in the pull request: https://github.com/apache/spark/pull/12143#discussion_r58877114 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaModelSelectionViaTrainValidationSplitExample.java --- @@ -33,6 +33,16 @@ /**

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-07 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12143#discussion_r58853491 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaModelSelectionViaTrainValidationSplitExample.java --- @@ -33,6 +33,16 @@ /**

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-206760116 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-206759969 **[Test build #55206 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55206/consoleFull)** for PR 12143 at commit

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-206760117 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-206758152 **[Test build #55206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55206/consoleFull)** for PR 12143 at commit

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-07 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-206756728 Jenkins retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-05 Thread yongtang
Github user yongtang commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-206069924 Thanks @jkbradley @holdenk. Both `JavaDeveloperApiExample.java` and `JavaSimpleTextClassificationPipeline.java` have been restored. Some of the

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205988320 Please do not delete JavaDeveloperApiExample.java AFAIK, this is the only code example we have for Java developers who want to build custom ML pipelines. --- If

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205978731 Awesome :) A few minor things found while reviewing: One thing I noticed while looking at the differences between the code we are deleting and the code we are

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-04 Thread yongtang
Github user yongtang commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205645213 Thanks @holdenk. Just tried with `SKIP_API=1 jekyll build` and the docs builds fine. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205599056 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205599057 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205598950 **[Test build #54926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54926/consoleFull)** for PR 12143 at commit

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205595351 **[Test build #54926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54926/consoleFull)** for PR 12143 at commit

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205590871 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-04 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205451276 Yay deleting code! :) Verified none of the removed examples are currently directly referenced in includes under docs/ - @yongtang still might be good for test purposes

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12143#issuecomment-205133204 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14301][Examples] Java examples code mer...

2016-04-03 Thread yongtang
GitHub user yongtang opened a pull request: https://github.com/apache/spark/pull/12143 [SPARK-14301][Examples] Java examples code merge and clean up. ## What changes were proposed in this pull request? This fix tries to remove duplicate Java code in examples/mllib and