Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-212182055
This is trivial but would be great if the title follows
`[SPARK-X][SQL]` format as described in
https://cwiki.apache.org/confluence/display/SPARK/Contributing+t
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r63999680
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -391,21 +393,24 @@ abstract class UnixTim
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-220533781
hi @rajeshbalamohan , sorry for the delay, do you wanna try this again?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-221437247
@rajeshbalamohan thanks again for working on this; it'd be great to have
this in 2.0. Do you have cycles to bring to this up to date and address
reviewer comments
Github user rajeshbalamohan commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-222408035
Sorry about the delay in responding to this. Will try to rebase and post
the patch asap.
---
If your project is set up for it, you can reply to this email and
GitHub user rajeshbalamohan opened a pull request:
https://github.com/apache/spark/pull/12105
SPARK-14321. [SQL] Reduce date format cost and string-to-date cost iâ¦
## What changes were proposed in this pull request?
Here is the generated code snippet when executing date f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-204227649
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-204228144
Jenkins, OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-204267311
**[Test build #2721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2721/consoleFull)**
for PR 12105 at commit
[`6fd07db`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-204296880
**[Test build #2721 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2721/consoleFull)**
for PR 12105 at commit
[`6fd07db`](https://
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-204441304
The problem is that this object is not thread-safe. Unless you know this
instance is only accessed by one thread, this potentially fails when accessed
concurrently.
-
Github user rajeshbalamohan commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-205082821
SDF declared in the generated code is not shared in multiple threads.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58320790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -59,6 +59,8 @@ object DateTimeUtils {
final val to
Github user rajeshbalamohan commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-205122837
Agreed. Thanks @srowen . Reverted calendar changes in DateTimeUtils in
recent commit.
---
If your project is set up for it, you can reply to this email and hav
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58715478
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -391,13 +391,14 @@ abstract class UnixTime e
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58715959
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -416,11 +419,17 @@ abstract class UnixTime e
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58716090
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -519,7 +530,10 @@ case class FromUnixTime(se
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58745694
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -416,11 +419,17 @@ abstract class UnixTime e
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58746649
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -519,7 +530,10 @@ case class FromUnixTime(se
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-206476854
@rajeshbalamohan Could you also update the eval() of UnixTime, FromUnixTime
and DateFormatClass?
---
If your project is set up for it, you can reply to this email and h
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-208000318
Ping @rajeshbalamohan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-20986
@rajeshbalamohan are you still working on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rajeshbalamohan commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-210202377
Sorry about the delay. I will share the update patch today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user rajeshbalamohan commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-210384204
Revised the patch addressing comments. Fixed eval() of UnixTime,
FromUnixTime. Haven't changed eval in DateFormatClass as i am not sure if
format can change in
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r59864421
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -368,7 +369,10 @@ abstract class UnixTime ex
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r59864380
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -355,6 +355,7 @@ abstract class UnixTime ext
Github user rajeshbalamohan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r60001514
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -368,7 +369,10 @@ abstract class Un
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r60020044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -391,21 +395,24 @@ abstract class UnixTime e
Github user rajeshbalamohan commented on the pull request:
https://github.com/apache/spark/pull/12105#issuecomment-211286426
In the generated code, it returns null if constFormat == null. So it is
not required to change the generated code.
---
If your project is set up for it, you c
29 matches
Mail list logo
