[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-206044794 LGTM, merging into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205974356 LGTM, merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205972258 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205972257 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205971890 **[Test build #55008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55008/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205935744 **[Test build #55008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55008/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205931010 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205931003 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205930613 **[Test build #54999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54999/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205896645 **[Test build #54999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54999/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205706099 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205706094 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205705544 **[Test build #54961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54961/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205672212 **[Test build #54961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54961/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205668448 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205668450 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205668342 **[Test build #54952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54952/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205648086 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205648092 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205647827 **[Test build #54953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54953/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205644723 **[Test build #54953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54953/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/12141#discussion_r58487027 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -36,7 +36,7 @@ test_that("Check masked functions", {

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/12141#discussion_r58486806 --- Diff: R/pkg/R/generics.R --- @@ -1152,6 +1152,10 @@ setGeneric("var_samp", function(x) { standardGeneric("var_samp") }) #' @export

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/12141#discussion_r58486779 --- Diff: R/pkg/inst/tests/testthat/test_context.R --- @@ -36,7 +36,7 @@ test_that("Check masked functions", {

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205641614 **[Test build #54952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54952/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205631191 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205631188 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205631001 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205630997 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205630936 **[Test build #54933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54933/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205630671 **[Test build #54946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54946/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205626673 **[Test build #54946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54946/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205623197 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205623199 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205623179 **[Test build #54938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54938/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205620702 **[Test build #54938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54938/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205619343 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205619347 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205619295 **[Test build #54934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54934/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/12141#discussion_r58480012 --- Diff: R/pkg/NAMESPACE --- @@ -265,6 +265,7 @@ exportMethods("%in%", "var_samp", "weekofyear",

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205613048 **[Test build #54934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54934/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205611248 **[Test build #54933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54933/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205605619 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205605626 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205605192 **[Test build #54930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54930/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-20566 **[Test build #54930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54930/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205599533 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205588443 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205588440 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205587956 **[Test build #54913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54913/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/12141#discussion_r58476009 --- Diff: R/pkg/NAMESPACE --- @@ -265,6 +265,7 @@ exportMethods("%in%", "var_samp", "weekofyear",

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/12141#discussion_r58475970 --- Diff: R/pkg/NAMESPACE --- @@ -265,6 +265,7 @@ exportMethods("%in%", "var_samp", "weekofyear",

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205581920 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205581924 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205581672 **[Test build #54912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54912/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205575393 Retest this please On Apr 4, 2016 6:09 PM, "UCB AMPLab" wrote: > Test FAILed. > Refer to this link for build results (access

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205570278 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205570248 **[Test build #54917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54917/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205570275 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205567501 @davies Addressed your comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205567331 @davies Addressed your comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205566507 **[Test build #54917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54917/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205557971 **[Test build #54913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54913/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-20345 **[Test build #54912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54912/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205551983 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205551979 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205551724 **[Test build #54906 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54906/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205550840 @brkyvz LGTM, only one minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12141#discussion_r58468936 --- Diff: R/pkg/R/functions.R --- @@ -2131,6 +2131,65 @@ setMethod("from_unixtime", signature(x = "Column"), column(jc) })

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12136#discussion_r58468177 --- Diff: python/pyspark/sql/functions.py --- @@ -1053,6 +1053,44 @@ def to_utc_timestamp(timestamp, tz): return

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12136#discussion_r58467899 --- Diff: python/pyspark/sql/functions.py --- @@ -1053,6 +1053,44 @@ def to_utc_timestamp(timestamp, tz): return

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12136#discussion_r58467419 --- Diff: python/pyspark/sql/functions.py --- @@ -1053,6 +1053,44 @@ def to_utc_timestamp(timestamp, tz): return

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205527448 **[Test build #54906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54906/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-04 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/12136#discussion_r58461759 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala --- @@ -365,20 +365,29 @@ abstract class TreeNode[BaseType <:

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205125718 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205125714 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205125324 **[Test build #54820 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54820/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205113031 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205113029 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205112805 **[Test build #54819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54819/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-205108060 **[Test build #54819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54819/consoleFull)** for PR 12141 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12136#issuecomment-205108064 **[Test build #54820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54820/consoleFull)** for PR 12136 at commit

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-03 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/12141 [SPARK-14353] Dataset Time Window `window` API for R ## What changes were proposed in this pull request? The `window` function was added to Dataset with [this