Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-210439965
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-210433724
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-210433732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-210433327
**[Test build #55921 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55921/consoleFull)**
for PR 12176 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-210419520
**[Test build #55921 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55921/consoleFull)**
for PR 12176 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-210419431
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r59852468
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -536,13 +532,16 @@ private[clustering] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r59848898
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -536,13 +532,16 @@ private[clustering] object OnlineLDAOptimizer {
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r59844091
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -536,13 +532,16 @@ private[clustering] object
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-209677538
LGTM too pending the doc update (thanks for that)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-209493926
@pravingadakh if you'll augment that doc a little bit more I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r59135877
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -536,13 +532,16 @@ private[clustering] object OnlineLDAOptimizer {
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-207929631
@srowen Added `@return` for the method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-207894385
@pravingadakh I'll merge if you'll doc the return value of this method.
That further justifies the change.
---
If your project is set up for it, you can reply to this
Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-206674436
Sean is right about the meanings of the return values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-206410312
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-206410316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-206410132
**[Test build #55113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55113/consoleFull)**
for PR 12176 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-206388932
**[Test build #55113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55113/consoleFull)**
for PR 12176 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-206388117
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-206119313
@jkbradley Could you please flag this PR for test build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-205952381
Ha fair enough. From poking around the internet I'm pretty sure the first
is an estimate of gamma, the topic distribution (as the comments say) and the
second are
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-205918384
I could document the returned values, but frankly I have no idea what those
values are. I can see the documentation of first returned value `gammad` in the
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-205882669
A-ha, understood about `.values`. This looks pretty reasonable. My only
question is, does it make sense conceptually that this method also returns a
list of IDs? it
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r58553918
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -542,10 +539,11 @@ private[clustering] object
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r58553056
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -440,12 +440,9 @@ final class OnlineLDAOptimizer extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r58519101
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -440,12 +440,9 @@ final class OnlineLDAOptimizer extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12176#discussion_r58518958
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -542,10 +539,11 @@ private[clustering] object OnlineLDAOptimizer {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12176#issuecomment-205741735
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/12176
[SPARK-14370][MLLIB]removed duplicate generation of ids in
OnlineLDAOptimizer
## What changes were proposed in this pull request?
Removed duplicated generation of `ids` in
31 matches
Mail list logo
