[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-27 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-28778 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-222081009 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-222081007 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-222080825 **[Test build #59466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59466/consoleFull)** for PR 12194 at commit [`4a7b2e8`](https://g

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-27 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-222080647 LGTM pending jenkins. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-27 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/12194#discussion_r64864622 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -127,45 +127,78 @@ case class ScriptTransformati

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-26 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-222068305 @rxin : Sorry for delay... was caught up in some other things. I have updated the PR now with the review comments. Re your suggestion about removing hive c

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-222068202 **[Test build #59466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59466/consoleFull)** for PR 12194 at commit [`4a7b2e8`](https://gi

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-26 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/12194#discussion_r64861172 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -127,45 +127,78 @@ case class ScriptTransformati

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-26 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/12194#discussion_r64861159 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -127,45 +127,78 @@ case class ScriptTransformati

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-222014891 @tejasapatil want to update this so we can merge it for 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-26 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12194#discussion_r64833050 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -127,45 +127,78 @@ case class ScriptTransformation(

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-25 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-221756020 With one minor suggestion this LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12194#discussion_r64680641 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -127,45 +127,78 @@ case class ScriptTransformation(

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-221448815 @tejasapatil on a related note, we'd want to remove as much hive code dependency as possible. One command that is left is ScriptTransformation. Would you have time to impl

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-221448631 @srowen want to review this? Given you reviewed the last transform pr. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-24 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-221436708 This patch looks good to me. @srowen / @JoshRosen can one of you please take a second look as well? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-24 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/12194#discussion_r64495331 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala --- @@ -127,45 +127,78 @@ case class ScriptTransforma

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-22 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-220848477 Can anyone please review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-18 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-220031022 Can anyone please review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219963233 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219963232 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219962963 **[Test build #58750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58750/consoleFull)** for PR 12194 at commit [`abd65d8`](https://g

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219942382 **[Test build #58750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58750/consoleFull)** for PR 12194 at commit [`abd65d8`](https://gi

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-17 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219941867 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219865153 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219865151 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219865022 **[Test build #58720 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58720/consoleFull)** for PR 12194 at commit [`524eb71`](https://g

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219854345 **[Test build #58720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58720/consoleFull)** for PR 12194 at commit [`524eb71`](https://gi

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-17 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-219853586 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-218319440 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-218319348 **[Test build #58286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58286/consoleFull)** for PR 12194 at commit [`e37e0aa`](https://g

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-218319442 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-218310777 **[Test build #58286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58286/consoleFull)** for PR 12194 at commit [`e37e0aa`](https://gi

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-10 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-218310372 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-209205949 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-209205945 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-209205565 **[Test build #55676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55676/consoleFull)** for PR 12194 at commit [`1054b71`](https://g

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-209187311 **[Test build #55676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55676/consoleFull)** for PR 12194 at commit [`1054b71`](https://gi

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-12 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-209185057 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207538996 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207538991 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207538696 **[Test build #55360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55360/consoleFull)** for PR 12194 at commit [`ebb5ea1`](https://g

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207509252 **[Test build #55360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55360/consoleFull)** for PR 12194 at commit [`ebb5ea1`](https://gi

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207508838 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207505249 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207505235 **[Test build #55358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55358/consoleFull)** for PR 12194 at commit [`e3899c3`](https://g

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207505246 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-207504610 **[Test build #55358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55358/consoleFull)** for PR 12194 at commit [`e3899c3`](https://gi

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-206098651 cc @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-206097196 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-206097201 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-206097091 **[Test build #55074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55074/consoleFull)** for PR 12194 at commit [`df48e1e`](https://g

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-206078586 **[Test build #55074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55074/consoleFull)** for PR 12194 at commit [`df48e1e`](https://gi

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-05 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-206075956 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-04-05 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/12194 [SPARK-14400] [SQL] ScriptTransformation does not fail the job for bad user command ## What changes were proposed in this pull request? - Refer to the Jira for the problem: jira : htt