[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user JustinPihony commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-220431230 I just updated the branch to have no conflicts. Again, either the code looks good to merge, or I can make JDBC a `CreatableRelationProvider` (but that comes with

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user JustinPihony commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-217359217 I can finish this next Monday(fix the conflicts that now exist), and will actually do that given the above comments. I'd still like to get an opinion on whether I

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-216445374 @rxin I also realised Python API is supporting properties as a dict having " arbitrary string tag/value",

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user maropu commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-214992526 Even if so, I think we need a kinda wrapper or something to safely convert `Properties` to `Map` because newbie users could easily & wrongly put

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user JustinPihony commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213662908 @HyukjinKwon I just posted on the JIRA the background of `Properties` and how reasonable it is to assume it can be converted to a `String`. --- If your project

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213568166 A possible problem was noticed (is `Properties` guaranteed to be converted to `String`?) in the JIRA before this PR and any evidence was not prodivded or said

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user JustinPihony commented on a diff in the pull request: https://github.com/apache/spark/pull/12601#discussion_r60752881 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -244,7 +244,11 @@ final class DataFrameWriter private[sql](df:

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user JustinPihony commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213463779 @HyukjinKwon You will notice that I opted to not deprecate jdbc as I don't think that would be the correct path anyway (unless all format methods were to be

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213397222 Question: I found a [PPT](http://www.slideshare.net/SparkSummit/structuring-spark-dataframes-datasets-and-streaming-by-michael-armbrust) which I think is used in

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213382156 I think I can rework based on this because it is anyway opened already. Excuse my ping @rxin --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213382065 BTW, it looks it is pretty general that `Properties` just works like `HashMap[String, String]` in most cases. Firstly, I just checked [java.sql.Driver

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12601#discussion_r60721164 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -244,7 +244,11 @@ final class DataFrameWriter private[sql](df:

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213298866 I think `Additional details` could be said in comments not in the PR description because PR description describes what the PR is. Maybe `Additional details` is not

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213297906 @JustinPihony I think we haven't reached the conclusion yet and haven't got any feedback, from committers, if we should deprecate `read.jdbc()` or support

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

GitHub user JustinPihony opened a pull request: https://github.com/apache/spark/pull/12601 [SPARK-14525][SQL] Make DataFrameWrite.save work for jdbc ## What changes were proposed in this pull request? This change modifies the implementation of DataFrameWriter.save such that

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-213274569 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your