Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215204718
Thank you so much, @hvanhovell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215203897
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215203971
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215202725
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215202728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215202447
**[Test build #57149 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57149/consoleFull)**
for PR 12421 at commit
[`b2ac335`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215198684
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215198685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215198368
**[Test build #57147 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57147/consoleFull)**
for PR 12421 at commit
[`152c6c2`](https://g
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215172349
@hvanhovell .
Thank you for squeezing your precious time for reviewing my PR several
times.
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215171546
**[Test build #57149 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57149/consoleFull)**
for PR 12421 at commit
[`b2ac335`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215170046
**[Test build #57147 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57147/consoleFull)**
for PR 12421 at commit
[`152c6c2`](https://gi
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61304575
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1343,17 +1343,32 @@ object DecimalAggregates ext
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61298823
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -177,6 +177,8 @@ case class WindowExec(
case e @
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61295168
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -430,4 +430,13 @@ class DataFrameAggregateSuite extends Que
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215058208
@dongjoon-hyun The PR is in pretty good shape. I left a few small
comments/questions.
---
If your project is set up for it, you can reply to this email and have you
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61242062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1343,17 +1343,32 @@ object DecimalAggregates extend
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61241988
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -177,6 +177,8 @@ case class WindowExec(
case e @ Win
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61240023
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -430,4 +430,13 @@ class DataFrameAggregateSuite extends QueryT
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215021880
@dongjoon-hyun I am gonna get to this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-215012244
Hi, @rxin .
Could you review and merge this PR?
This fixes `RuntimeException` error for Window aggregation queries.
---
If your project is set up for it,
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214812007
Hi, @hvanhovell .
Could you review this PR when you have some time?
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214628538
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214628541
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214628385
**[Test build #56968 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56968/consoleFull)**
for PR 12421 at commit
[`14fe6b9`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214617100
**[Test build #56968 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56968/consoleFull)**
for PR 12421 at commit
[`14fe6b9`](https://gi
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214616662
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214570700
More test cases are added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214569512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214569510
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214569373
**[Test build #56935 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56935/consoleFull)**
for PR 12421 at commit
[`45beddd`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214554325
**[Test build #56935 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56935/consoleFull)**
for PR 12421 at commit
[`45beddd`](https://gi
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12421#issuecomment-214207072
Hi, @hvanhovell .
Now, it's ready for review again.
Thank you so much. I couldn't fix this without your help.
---
If your project is set up for it, you ca
34 matches
Mail list logo
