[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211607320 **[Test build #56129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56129/consoleFull)** for PR 12423 at commit [`34f1724`](https://g

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211607618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211607619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/12423#discussion_r60161650 --- Diff: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java --- @@ -118,27 +112,6 @@ public voi

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12423#discussion_r60162836 --- Diff: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java --- @@ -118,27 +112,6 @@ public void tes

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211698611 Alright merging in master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-15 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/12423 [SPARK-14667] Remove HashShuffleManager ## What changes were proposed in this pull request? The sort shuffle manager has been the default since Spark 1.2. It is time to remove the old hash shuffle

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-210618025 **[Test build #55949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55949/consoleFull)** for PR 12423 at commit [`3a448fa`](https://gi

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-210663982 **[Test build #55949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55949/consoleFull)** for PR 12423 at commit [`3a448fa`](https://g

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-210664244 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-210664240 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-21041 I will leave this open for a few days to give other people a chance to comment. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-17 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211219477 I think the following should be deleted 1. [FileShuffleBlockResolver.scala](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/shuffle/F

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-17 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211227447 Thanks - updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211240301 **[Test build #2809 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2809/consoleFull)** for PR 12423 at commit [`2464a15`](https://g

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211278465 **[Test build #2809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2809/consoleFull)** for PR 12423 at commit [`2464a15`](https://

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211487610 **[Test build #56081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56081/consoleFull)** for PR 12423 at commit [`2464a15`](https://gi

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211547820 **[Test build #56081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56081/consoleFull)** for PR 12423 at commit [`2464a15`](https://g

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211548055 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211548051 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14667] Remove HashShuffleManager

2016-04-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12423#issuecomment-211557642 **[Test build #56129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56129/consoleFull)** for PR 12423 at commit [`34f1724`](https://gi