Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61669718
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,64 @@ public UnsafeArrayData copy() {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215940963
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215939422
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215939423
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215939391
**[Test build #57403 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57403/consoleFull)**
for PR 12640 at commit
[`b10845c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215932497
**[Test build #57403 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57403/consoleFull)**
for PR 12640 at commit
[`b10845c`](https://gi
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215932443
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215932258
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215932250
**[Test build #57399 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57399/consoleFull)**
for PR 12640 at commit
[`b10845c`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215932260
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215931603
LGTM pending Jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215931405
**[Test build #57399 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57399/consoleFull)**
for PR 12640 at commit
[`b10845c`](https://gi
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215930973
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215921309
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215921311
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215921297
**[Test build #57387 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57387/consoleFull)**
for PR 12640 at commit
[`b10845c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215920860
**[Test build #57387 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57387/consoleFull)**
for PR 12640 at commit
[`b10845c`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215656518
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215656516
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215656335
**[Test build #57320 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57320/consoleFull)**
for PR 12640 at commit
[`537e363`](https://g
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61542453
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61541291
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy()
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61540619
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/UDTSerializationBenchmark.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Soft
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61540468
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/UDTSerializationBenchmark.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache S
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215641970
**[Test build #57320 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57320/consoleFull)**
for PR 12640 at commit
[`537e363`](https://gi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61539393
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy()
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61529874
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/UDTSerializationBenchmark.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache S
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61509114
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,78 @@ public UnsafeArrayData copy() {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61509122
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy() {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61505845
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/UDTSerializationBenchmark.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Soft
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61486213
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy() {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61485789
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/UDTSerializationBenchmark.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Soft
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215473555
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215473565
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215473255
**[Test build #57253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57253/consoleFull)**
for PR 12640 at commit
[`c6c3584`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215441061
**[Test build #57253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57253/consoleFull)**
for PR 12640 at commit
[`c6c3584`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215386110
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215386113
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215385781
**[Test build #57239 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57239/consoleFull)**
for PR 12640 at commit
[`f6964f9`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215374433
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215374404
**[Test build #57241 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57241/consoleFull)**
for PR 12640 at commit
[`d445022`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215374427
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215372214
**[Test build #57241 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57241/consoleFull)**
for PR 12640 at commit
[`d445022`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215370955
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215370951
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215370706
**[Test build #57237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57237/consoleFull)**
for PR 12640 at commit
[`a7b7694`](https://g
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61399541
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/UDTSerializationBenchmark.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache S
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61397517
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/UDTSerializationBenchmark.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache S
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215363656
**[Test build #57239 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57239/consoleFull)**
for PR 12640 at commit
[`f6964f9`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215355291
**[Test build #57237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57237/consoleFull)**
for PR 12640 at commit
[`a7b7694`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215352568
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215352565
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215352327
**[Test build #57230 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57230/consoleFull)**
for PR 12640 at commit
[`f4d2cbb`](https://g
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61389927
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy()
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61389700
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy()
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215343973
@cloud-fan Could you also update the benchmark?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61387931
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy() {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61387937
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy() {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61386974
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy() {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61386945
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy() {
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/12640#issuecomment-215338341
@cloud-fan , @mengxr, it would be worth to add ```final``` to a declaration
of ```UnsafeArrayData ``` for encouraging method inlining by JIT compiler, as
follows:
```
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61383378
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,62 @@ public UnsafeArrayData copy()
63 matches
Mail list logo
