Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216939189
Merging to master / 2.0. Thanks again @lw-lin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216714511
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216714507
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216714401
**[Test build #57691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57691/consoleFull)**
for PR 12797 at commit
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216705209
@marmbrus @zsxwing thank you for the patient review! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61977204
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,13 @@ case class
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216704764
LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61977039
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,13 @@ case class
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61976675
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,13 @@ case class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61976436
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,13 @@ case class
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61976475
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala ---
@@ -142,7 +142,10 @@ trait StreamTest extends QueryTest with Timeouts {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216701369
**[Test build #57691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57691/consoleFull)**
for PR 12797 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/12797#issuecomment-216616857
Looks pretty good. @lw-lin could you address the comments and resolve the
conflicts?
---
If your project is set up for it, you can reply to this email and have your
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61928352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,22 @@ case class
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61837747
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ProcessingTimeExecutorSuite.scala
---
@@ -21,19 +21,41 @@ import
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61837727
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,22 @@ case class
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12797#discussion_r61837469
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -65,8 +65,22 @@ case class
18 matches
Mail list logo
