Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13008
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-220201533
Thanks! Merging to master and branch 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r63803944
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/FPGrowth.scala ---
@@ -116,7 +116,7 @@ object FPGrowthModel extends Loader[FPGrowthModel[_]] {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r63726478
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/FPGrowth.scala ---
@@ -116,7 +116,7 @@ object FPGrowthModel extends Loader[FPGrowthModel[_]] {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-220002209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-220002208
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-220001928
**[Test build #58771 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58771/consoleFull)**
for PR 13008 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219983946
**[Test build #58771 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58771/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219929255
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219929253
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219929172
**[Test build #58741 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58741/consoleFull)**
for PR 13008 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219920209
**[Test build #58741 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58741/consoleFull)**
for PR 13008 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219734656
**[Test build #58695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58695/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219734722
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219734720
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219725454
**[Test build #58695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58695/consoleFull)**
for PR 13008 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219724329
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219669778
**[Test build #58678 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58678/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219669826
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219669830
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219664628
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219664603
**[Test build #58680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58680/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219664629
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219662340
**[Test build #58680 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58680/consoleFull)**
for PR 13008 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-219661237
**[Test build #58678 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58678/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218706303
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218706306
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218706135
**[Test build #58462 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58462/consoleFull)**
for PR 13008 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218688181
**[Test build #58462 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58462/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218686965
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218686962
**[Test build #58461 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58461/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218686967
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218686177
**[Test build #58461 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58461/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218672986
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218672864
**[Test build #58451 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58451/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218672983
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218670622
Oh actually we did document it in the java doc of `Row`, and says users
should use `Seq` for array type. see
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218670057
looks like we haven't documented what kind of field object types is allowed
in a `Row`, let me find a place to document it.
---
If your project is set up for it,
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218669218
I see. Seems like a API change that at least we need to document.
Is there any performance implication?
also cc @mengxr
---
If your project is set up
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218668967
Unlike `CatalystConverter`, `RowEncoder` is stricter about the input
external type, e.g. users must use `Seq` for `ArrayType`, but `CatalystConvert`
also allows
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218665830
what is the cause of those failed tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-21866
yea, the new commit should fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218665223
legitimate issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218664669
**[Test build #58450 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58450/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218664688
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218664687
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218662389
**[Test build #58451 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58451/consoleFull)**
for PR 13008 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218661393
**[Test build #58450 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58450/consoleFull)**
for PR 13008 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218661098
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218661110
LGTM pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62965499
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with
SharedSQLContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62965137
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62964943
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with
SharedSQLContext
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62964815
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with
SharedSQLContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62964694
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62963859
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with
SharedSQLContext
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218649776
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218649754
**[Test build #58437 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58437/consoleFull)**
for PR 13008 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218649778
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-218646586
**[Test build #58437 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58437/consoleFull)**
for PR 13008 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62947902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -113,8 +113,8 @@ object ScalaReflection extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62947857
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -490,8 +490,8 @@ class SparkSession private(
// TODO: use
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62939213
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -113,8 +113,8 @@ object ScalaReflection extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13008#discussion_r62939286
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -490,8 +490,8 @@ class SparkSession private(
// TODO: use
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-217902758
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-217902756
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13008#issuecomment-217902709
**[Test build #58147 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58147/consoleFull)**
for PR 13008 at commit
67 matches
Mail list logo
