Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-221133646
@rdblue Thanks. That is a good point :) I am closing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yhuai closed the pull request at:
https://github.com/apache/spark/pull/13236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rdblue commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-221083829
@yhuai, I know that the IsolatedClientLoader is used to load multiple
versions of Hive, but Hive should be able to use the version of Hadoop that
Spark has already
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-221080895
We support different versions of Hive metastore (for example, Spark depends
on Hive 1.2.1 but we can talk to a metastore using Hive 0.12). Also, the Hadoop
used by this
Github user rdblue commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-221074125
Why is Hive's ClassLoader loading Hadoop classes itself rather than
delegating to the ClassLoader that is responsible for Hadoop? Hive should be
using shims to interact
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-221069266
I can create a Hadoop Configuration inside HiveClientImpl and use it to
create the HiveConf. The main issue is that we cannot pass a Hadoop
Configuration in a
Github user rdblue commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-221063988
@yhuai, Hive uses shims to be compatible with Hadoop 1 and Hadoop 2. I
think it would be better to use the existing mechanism in Hive to deal with
this.
I know
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-221050299
@rdblue Thank you for looking at this!
The reason that I added the flag to disable sharing Hadoop classes is that
hadoops used by Spark and metastore client may
Github user rdblue commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-221033268
I don't think a map preserves behavior. Hadoop `Configuration` instances
have a set of final properties that can't be changed. This loses that
information and then
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220862905
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220862906
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220862857
**[Test build #59115 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59115/consoleFull)**
for PR 13236 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13236#discussion_r64157490
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -73,7 +74,7 @@ import org.apache.spark.util.{CircularBuffer,
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13236#discussion_r64157471
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -73,7 +74,7 @@ import org.apache.spark.util.{CircularBuffer,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220859959
**[Test build #59115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59115/consoleFull)**
for PR 13236 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220753234
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220753236
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220753220
**[Test build #59050 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59050/consoleFull)**
for PR 13236 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220750855
**[Test build #59050 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59050/consoleFull)**
for PR 13236 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220750748
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220750504
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220750500
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220750462
**[Test build #59049 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59049/consoleFull)**
for PR 13236 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220749880
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220749879
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220749828
**[Test build #59046 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59046/consoleFull)**
for PR 13236 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220747250
**[Test build #59049 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59049/consoleFull)**
for PR 13236 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13236#discussion_r64123606
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -129,6 +129,14 @@ private[spark] object HiveUtils extends Logging {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220745477
**[Test build #59046 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59046/consoleFull)**
for PR 13236 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220745379
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220745381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220745292
**[Test build #59043 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59043/consoleFull)**
for PR 13236 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13236#issuecomment-220738248
**[Test build #59043 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59043/consoleFull)**
for PR 13236 at commit
GitHub user yhuai opened a pull request:
https://github.com/apache/spark/pull/13236
[SPARK-15455] For IsolatedClientLoader, we need to provide a conf to
disable sharing Hadoop classes
## What changes were proposed in this pull request?
(Please fill in changes proposed in
34 matches
Mail list logo
