Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-48701090
QA tests have started for PR 955. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16558/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-48702465
QA tests have started for PR 955. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16561/consoleFull
---
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14796461
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/OnlineSummarizer.scala ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-48561923
@dbtsai About the package name, `stat` is the standard acronym for
statistics instead of `stats`. Checkout the urls returned by Google:
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749219
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala
---
@@ -370,10 +239,9 @@ class RowMatrix(
* Computes
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749221
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/OnlineSummarizer.scala ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749223
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/OnlineSummarizer.scala ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749222
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/OnlineSummarizer.scala ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749225
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/OnlineSummarizer.scala ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749226
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/OnlineSummarizer.scala ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749235
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/OnlineSummarizerSuite.scala ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749229
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/stat/OnlineSummarizer.scala ---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749232
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/OnlineSummarizerSuite.scala ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749234
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/OnlineSummarizerSuite.scala ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749237
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/OnlineSummarizerSuite.scala ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749243
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/OnlineSummarizerSuite.scala ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749276
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/OnlineSummarizerSuite.scala ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/955#discussion_r14749377
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/OnlineSummarizerSuite.scala ---
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45309135
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45322839
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45327623
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15504/
---
If your project
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45292634
@dbtsai The current workaround is excluding it in
`project/MimaExcludes.scala`. Please check the examples there. At least, we
need to make Jenkins happy.
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45297366
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45297370
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45297396
k... better to have Mima exclude the private class automatically, or we can
have annotation for the private class.
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45299828
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45299830
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15492/
---
If your project is set up for it, you can
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45124672
@mengxr Get you. It's false-positive error. Do you have any comment or
feedback moving it out as public api? I'm building a feature scaling api in
MlUtils which depends on
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/955
[SPARK-1969][MLlib] Public available online summarizer for mean, variance,
min, and max
It basically moved the private ColumnStatisticsAggregator class from
RowMatrix to public available
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45021851
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45022509
MultivariateStatisticalSummary is a public API -- we can't rename it
arbitrarily. Why does it need to be renamed?
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45021837
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45023171
Since the Statistical in MultivariateStatisticalSummary is already in the
package name as stat, I think it worths to have a concise name. Also, most
people spell the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45024074
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45024088
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45024214
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45024583
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45024565
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45026137
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45026777
Don't know why jenkins is not happy with removing private class
ColumnStatisticsAggregator(private val n: Int). After all, it's a private
class.
---
If your project is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45028406
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15408/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/955#issuecomment-45028404
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
42 matches
Mail list logo
