[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread darabos
GitHub user darabos opened a pull request: https://github.com/apache/spark/pull/1329 [SPARK-2403] Catch all errors during serialization in DAGScheduler https://issues.apache.org/jira/browse/SPARK-2403 Spark hangs for us whenever we forget to register a class with Kryo. This

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48333968 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/1329#discussion_r14664065 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -768,6 +768,10 @@ class DAGScheduler( abortStage(stage,

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48367185 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48367175 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread darabos
Github user darabos commented on a diff in the pull request: https://github.com/apache/spark/pull/1329#discussion_r14665377 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -768,6 +768,10 @@ class DAGScheduler( abortStage(stage,

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48369131 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48369146 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread darabos
Github user darabos commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48368953 Thanks! I've added the suggested changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48370178 LGTM. Regarding the initial problem you observed, did you see the actual exception via the DAGScheduler's OneForOneStrategy failure? Or were there no log messages

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48372856 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48372857 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16408/ --- If your

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread darabos
Github user darabos commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48373710 LGTM. Regarding the initial problem you observed, did you see the actual exception via the DAGScheduler's OneForOneStrategy failure? Or were there no log messages

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48374016 Great, thanks! I just wanted to make sure it was actually printed somewhere, although I understand the behavior was not ideal. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48374163 Merged into master and branch-1.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48375496 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16409/ --- If your

[GitHub] spark pull request: [SPARK-2403] Catch all errors during serializa...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1329#issuecomment-48375494 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.