[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15732257 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1727 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50972970 LGTM. Merged into both master and branch-1.1. Thanks!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50972891 QA results for PR 1727:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):Re-index class labels in a

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50971402 QA tests have started for PR 1727. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17773/consoleFull --- If

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15730605 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729992 --- Diff: python/pyspark/mllib/util.py --- @@ -29,9 +30,9 @@ class MLUtils: Helper methods to load, save and pre-process data used in MLlib. "

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729984 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729989 --- Diff: python/pyspark/mllib/tests.py --- @@ -256,9 +276,19 @@ def test_classification(self): self.assertTrue(nb_model.predict(features[2]) <= 0)

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729986 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729990 --- Diff: python/run-tests --- @@ -71,6 +71,7 @@ run_test "pyspark/mllib/random.py" run_test "pyspark/mllib/recommendation.py" run_test "pyspark/mllib

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729987 --- Diff: python/pyspark/mllib/tests.py --- @@ -127,9 +128,19 @@ def test_classification(self): self.assertTrue(nb_model.predict(features[2]) <= 0)

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729981 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729983 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729985 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15729982 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,129 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread manishamde
Github user manishamde commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50967302 Not very familiar with the python API but the DT changes look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50956653 QA results for PR 1727:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):Re-index class labels in a

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50955594 QA tests have started for PR 1727. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17758/consoleFull --- If

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50955507 @mengxr Hopefully good to go if Jenkins agrees. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50949260 QA results for PR 1727:- This patch FAILED unit tests.- This patch merges cleanly- This patch adds the following public classes (experimental):class DecisionTreeModel(obj

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725584 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# co

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725574 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725504 --- Diff: python/pyspark/mllib/tree.py --- @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725482 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -459,6 +466,76 @@ class PythonMLLibAPI extends Serializable {

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725411 --- Diff: python/pyspark/mllib/tree.py --- @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725375 --- Diff: python/pyspark/mllib/tree.py --- @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725364 --- Diff: python/pyspark/mllib/tree.py --- @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725329 --- Diff: python/pyspark/mllib/tree.py --- @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725310 --- Diff: python/pyspark/mllib/tree.py --- @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725151 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -19,6 +19,8 @@ package org.apache.spark.mllib.api.python

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725100 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# co

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725093 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# co

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1727#discussion_r15725089 --- Diff: examples/src/main/python/mllib/tree.py --- @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# co

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1727#issuecomment-50947405 QA tests have started for PR 1727. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17721/consoleFull --- If

[GitHub] spark pull request: [SPARK-2478] [mllib] DecisionTree Python API

2014-08-01 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/1727 [SPARK-2478] [mllib] DecisionTree Python API Added experimental Python API for Decision Trees. API: * class DecisionTreeModel ** predict() for single examples and RDDs, taking both