[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1720 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1720#issuecomment-50943502 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1720#issuecomment-50943393 QA results for PR 1720:- This patch PASSES unit tests.- This patch merges cleanly- This patch adds no public classesFor more information see test ouptut:https://amplab.c

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1720#issuecomment-50942241 LGTM. Waiting for Jenkins ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1720#discussion_r15722274 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -42,6 +42,18 @@ class DecisionTreeSuite extends FunSuite with LocalS

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1720#discussion_r15722196 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala --- @@ -522,28 +522,36 @@ object DecisionTree extends Serializable with Logging

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread manishamde
Github user manishamde commented on the pull request: https://github.com/apache/spark/pull/1720#issuecomment-50941616 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread manishamde
Github user manishamde commented on a diff in the pull request: https://github.com/apache/spark/pull/1720#discussion_r15722106 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -42,6 +42,18 @@ class DecisionTreeSuite extends FunSuite with Lo

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread manishamde
Github user manishamde commented on a diff in the pull request: https://github.com/apache/spark/pull/1720#discussion_r15722046 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala --- @@ -522,28 +522,36 @@ object DecisionTree extends Serializable with Loggi

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1720#issuecomment-50939553 QA tests have started for PR 1720. This patch merges cleanly. View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17702/consoleFull --- If

[GitHub] spark pull request: [SPARK-2796] [mllib] DecisionTree bug fix: ord...

2014-08-01 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/1720 [SPARK-2796] [mllib] DecisionTree bug fix: ordered categorical features Bug: In DecisionTree, the method sequentialBinSearchForOrderedCategoricalFeatureInClassification() indexed bins from 0 to (