[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-26 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-53383270 @andrewor14 @pwendell @srowen As my branch is not up to date, I decide to close this and submit a new PR. Please Review It :

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-26 Thread uncleGen
Github user uncleGen closed the pull request at: https://github.com/apache/spark/pull/2076 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-53353689 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-53354305 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19166/consoleFull) for PR 2076 at commit

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-53354405 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19166/consoleFull) for PR 2076 at commit

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2076#discussion_r16688834 --- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala --- @@ -73,8 +73,9 @@ class StorageListener(storageStatusListener:

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2076#discussion_r16688959 --- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala --- @@ -68,7 +68,8 @@ private[spark] class CacheManager(blockManager: BlockManager)

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-25 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2076#discussion_r16688997 --- Diff: core/src/test/scala/org/apache/spark/ui/UISuite.scala --- @@ -141,4 +141,33 @@ class UISuite extends FunSuite {

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-23 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-53144395 @pwendell Okay! I will add them as soon as possible and pay more attention. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-23 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-53159750 @andrewor14 - can you take a look at this patch? IIRC you worked on this code most recently. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-22 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2076#discussion_r16628876 --- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala --- @@ -68,7 +68,8 @@ private[spark] class CacheManager(blockManager: BlockManager)

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-22 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/2076#discussion_r16628889 --- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala --- @@ -73,8 +73,9 @@ class StorageListener(storageStatusListener:

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-53143325 Thanks for these fixes! When contributing fixes like this please write a unit test to expose the issue. That makes it crystal clear what is being fixed. --- If your

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2076#discussion_r16530145 --- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala --- @@ -73,8 +73,9 @@ class StorageListener(storageStatusListener:

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-21 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-52908740 @srowen yes! Not only in StorageTab, ExectutorTab may also lose some rdd-infos which have been overwritten by following rdd in a same task. StorageTab: when

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-20 Thread uncleGen
GitHub user uncleGen opened a pull request: https://github.com/apache/spark/pull/2076 [SPARK-3170][CORE]: Bug Fix in Storage UI current compeleted stage only need to remove its own partitions that are no longer cached. Currently, Storage in Spark UI may lost some rdds which are

[GitHub] spark pull request: [SPARK-3170][CORE]: Bug Fix in Storage UI

2014-08-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2076#issuecomment-52878313 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your