Github user bbejeck commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-74133969
Closing this pull request in deference to the work being done in PR #4547
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bbejeck closed the pull request at:
https://github.com/apache/spark/pull/3872
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-74124497
@bbejeck Yes, please close yours. We can continue the work in #4547. Also,
feel free to leave comments in that PR. Thank you for working on it!
---
If your project is set
Github user bbejeck commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-74109086
@yhuai , @marmbrus , @rxin should I close out my pull request, or would
both of these be combined somehow?
---
If your project is set up for it, you can reply to this em
Github user bbejeck commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-74014827
@yhuai I think it's a good idea, nice work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-74004052
@bbejeck Thank you for working on this. I made another version based on
yours (see #4547). What do you think about that approach (returning a DataFrame
containing names of
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-70356398
[Test build #25696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25696/consoleFull)
for PR 3872 at commit
[`4ef099b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-70356399
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user bbejeck commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-70354998
Addressed latest comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-70355011
[Test build #25696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25696/consoleFull)
for PR 3872 at commit
[`4ef099b`](https://githu
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r23066523
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -383,6 +383,19 @@ private[hive] class HiveMetastoreCatalog(hive:
H
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69530707
[Test build #25396 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25396/consoleFull)
for PR 3872 at commit
[`88c410d`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69530709
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69528766
[Test build #25394 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25394/consoleFull)
for PR 3872 at commit
[`90cbd43`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69528770
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69528345
[Test build #25396 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25396/consoleFull)
for PR 3872 at commit
[`88c410d`](https://githu
Github user bbejeck commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69528339
@OopsOutOfMemory removed all empty lines, thanks for checking!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22774314
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -152,6 +160,16 @@ trait OverrideCatalog extends Cat
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22774304
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -116,6 +116,21 @@ class HiveContext(sc: SparkContext) extends
SQ
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22774306
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ShowTablesSuite.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Fou
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22774305
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ShowTablesSuite.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Fou
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22774295
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -152,6 +160,16 @@ trait OverrideCatalog extends Cat
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22774291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -60,6 +60,10 @@ trait Catalog {
protected de
Github user bbejeck commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69526444
I believe I've made all suggested changes, branch was out of date so it's
been rebased, just waiting for tests to finish. Thanks to @marmbrus and @rxin
for the guidanc
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69526168
[Test build #25394 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25394/consoleFull)
for PR 3872 at commit
[`90cbd43`](https://githu
Github user bbejeck commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69525648
Fixing style tests, thought I ran it locally...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69525573
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69525572
[Test build #25393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25393/consoleFull)
for PR 3872 at commit
[`a42c963`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69525536
[Test build #25393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25393/consoleFull)
for PR 3872 at commit
[`a42c963`](https://githu
Github user bbejeck commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22766302
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -157,6 +163,15 @@ trait OverrideCatalog extends Catalog {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22765201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -157,6 +163,15 @@ trait OverrideCatalog extends Catalog {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22765197
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ListTablesSuite.scala ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22765194
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ListTablesSuite.scala ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22765188
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ListTablesSuite.scala ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22765190
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ListTablesSuite.scala ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22765172
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -117,6 +117,11 @@ class HiveContext(sc: SparkContext) extends
SQLContext(sc
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22765171
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -293,6 +293,13 @@ class SQLContext(@transient val sparkContext:
SparkContext)
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22765164
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -84,6 +86,10 @@ class SimpleCatalog(val caseSensitive: Boolean
Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22764598
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ListTablesSuite.scala ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foun
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69484420
[Test build #25371 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25371/consoleFull)
for PR 3872 at commit
[`a21b732`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69484422
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user bbejeck commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69483645
I need to merge in new changes then I will push the branch again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69482839
[Test build #25371 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25371/consoleFull)
for PR 3872 at commit
[`a21b732`](https://githu
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22762425
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -293,6 +293,13 @@ class SQLContext(@transient val sparkContext:
SparkContext)
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3872#issuecomment-69474553
Thanks for working on this!
/cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3872#discussion_r22762242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -41,6 +41,8 @@ trait Catalog {
def unregister
46 matches
Mail list logo
