Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58950576
Thanks for working on this huge feature! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18739665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,44 @@ trait HiveTypeCoercion {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18739656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,44 @@ trait HiveTypeCoercion {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58736899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58736896
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21615/consoleFull)
for PR 2344 at commit
[`f15074a`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58735889
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21615/consoleFull)
for PR 2344 at commit
[`f15074a`](https://github.com/ap
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58735806
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58665080
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58665073
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21594/consoleFull)
for PR 2344 at commit
[`f15074a`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58660519
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21594/consoleFull)
for PR 2344 at commit
[`f15074a`](https://github.com/ap
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58659730
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58658714
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21593/consoleFull)
for PR 2344 at commit
[`f15074a`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58658721
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58657652
I guess this one is related:
https://github.com/apache/spark/commit/411cf29fff011561f0093bb6101af87842828369
---
If your project is set up for it, you can reply to thi
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58657404
Seems we are getting something wrong with orc in jenkins... My local test
is fine.
---
If your project is set up for it, you can reply to this email and have your
re
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58656123
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58656118
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21592/consoleFull)
for PR 2344 at commit
[`2038085`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58655457
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21591/consoleFull)
for PR 2344 at commit
[`00fe81f`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58655469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18705174
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,44 @@ trait HiveTypeCoercion {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58654642
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21593/consoleFull)
for PR 2344 at commit
[`f15074a`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58652251
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21592/consoleFull)
for PR 2344 at commit
[`2038085`](https://github.com/ap
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18704345
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,44 @@ trait HiveTypeCoercion {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58651729
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21591/consoleFull)
for PR 2344 at commit
[`00fe81f`](https://github.com/ap
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58646718
I can see most of the reviews are focused on comparing and ordering. I'd
like to fix those comparing rules in a separated PR. I tested what you declared
here the othe
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58639081
Left some minor comments, otherwise LGTM. Also, do we want to add Python
API in this PR or a separate one?
---
If your project is set up for it, you can reply to this
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18698218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnType.scala ---
@@ -376,8 +395,8 @@ private[sql] sealed abstract class
ByteArrayColumn
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18698063
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/columnar/ColumnStats.scala ---
@@ -190,6 +190,24 @@ private[sql] class StringColumnStats extends
Col
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18697748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -56,7 +60,9 @@ case class Cast(child: Expression, dataTyp
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18696379
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,44 @@ trait HiveTypeCoercion {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18695986
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,44 @@ trait HiveTypeCoercion {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58619031
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21577/consoleFull)
for PR 2344 at commit
[`0df6ea1`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58619034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58616217
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21577/consoleFull)
for PR 2344 at commit
[`0df6ea1`](https://github.com/ap
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18686823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -181,6 +181,18 @@ case object TimestampType extends Nati
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58604586
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/329/consoleFull)
for PR 2344 at commit
[`0c339b0`](https://github.com/
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18685528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -181,6 +181,18 @@ case object TimestampType extends Native
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58600181
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/329/consoleFull)
for PR 2344 at commit
[`0c339b0`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58303279
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/2
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58303274
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21442/consoleFull)
for PR 2344 at commit
[`0c339b0`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-58299209
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21442/consoleFull)
for PR 2344 at commit
[`0c339b0`](https://github.com/ap
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57555702
I'm fine with finishing this in another PR, but can you remove the failing
test from the whitelist? Thanks!
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57554545
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/238/consoleFull)
for PR 2344 at commit
[`f4058ab`](https://github.com/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57550528
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/238/consoleFull)
for PR 2344 at commit
[`f4058ab`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57081730
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57081729
**[Tests timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20933/consoleFull)**
after a configured wait of `120m`.
---
If your project i
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57079131
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20933/consoleFull)
for PR 2344 at commit
[`f4058ab`](https://github.com/ap
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57079061
Hive is really strange dealing with date, there's still some inconsistency
between, but I think it is better to update in following PRs.
---
If your project is set u
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18126862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,52 @@ trait HiveTypeCoercion {
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18126726
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,52 @@ trait HiveTypeCoercion {
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57062345
Sorry for the delay, this week has been very busy! I'd like to merge this
soon, only one small question.
---
If your project is set up for it, you can reply to this em
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r18125250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -220,20 +220,52 @@ trait HiveTypeCoercion {
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-57057116
@marmbrus , just in case it will be out of date soon...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56619771
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20737/consoleFull)
for PR 2344 at commit
[`be6a958`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56619774
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20737/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56617051
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20737/consoleFull)
for PR 2344 at commit
[`be6a958`](https://github.com/ap
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56616986
@marmbrus , I have updated on current master and run sbt tests locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56575927
Yeah, I think this is probably ready to merge. Mind updating / resolving
conflicts?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56342088
@adrian-wang clarified some of my concerns offline, I think generally it's
ready to be merged. @marmbrus , @liancheng , any more comments on this?
---
If your pro
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56336063
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20647/consoleFull)
for PR 2344 at commit
[`8e91db0`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56332589
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20647/consoleFull)
for PR 2344 at commit
[`8e91db0`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56329240
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20642/consoleFull)
for PR 2344 at commit
[`92b31b4`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56328916
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20640/consoleFull)
for PR 2344 at commit
[`e3b12af`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56327272
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20642/consoleFull)
for PR 2344 at commit
[`92b31b4`](https://github.com/ap
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56327262
have rebased and addressed comments from @chenghao-intel .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17832080
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -170,6 +170,18 @@ case object TimestampType extends Nati
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56327106
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20640/consoleFull)
for PR 2344 at commit
[`e3b12af`](https://github.com/ap
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17766373
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -170,6 +170,18 @@ case object TimestampType extends Nati
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17765726
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -170,6 +170,18 @@ case object TimestampType extends N
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17765733
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -170,6 +170,18 @@ case object TimestampType extends N
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17765755
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/api/java/DateType.java ---
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Found
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56032559
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20539/consoleFull)
for PR 2344 at commit
[`252e84a`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56028120
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20539/consoleFull)
for PR 2344 at commit
[`252e84a`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56022043
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20537/consoleFull)
for PR 2344 at commit
[`458c113`](https://github.com/a
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17718951
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -177,6 +223,8 @@ case class Cast(child: Expression, dat
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56018966
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20537/consoleFull)
for PR 2344 at commit
[`458c113`](https://github.com/ap
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-56018809
Though Hive would throw exception when cast int to date, I think it doesn't
matter if not obey, because query exit with exception is considered a failure
in `runHive`
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17711980
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -221,19 +221,35 @@ trait HiveTypeCoercion {
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17710025
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -140,6 +147,39 @@ case class Cast(child: Expression, da
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17710004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -95,6 +100,8 @@ case class Cast(child: Expression, data
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55983850
A few comments on returns null V.S. raise exception in `Cast`, and which is
the more wider type for `Date` and `Timestamp`, the other LGTM.
---
If your project is
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17704236
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -177,6 +223,8 @@ case class Cast(child: Expression,
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17704067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -140,6 +147,39 @@ case class Cast(child: Expression,
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17704012
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -140,6 +147,39 @@ case class Cast(child: Expression,
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17703950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -140,6 +147,39 @@ case class Cast(child: Expression,
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17703854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -95,6 +100,8 @@ case class Cast(child: Expression, d
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17703775
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -221,19 +221,35 @@ trait HiveTypeCoercion {
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2344#discussion_r17703765
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -221,19 +221,35 @@ trait HiveTypeCoercion {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55969213
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20495/consoleFull)
for PR 2344 at commit
[`413f946`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55968540
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20495/consoleFull)
for PR 2344 at commit
[`413f946`](https://github.com/ap
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55967788
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55889454
Just rebase code, the failure is in spark-core and not in this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55877253
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20463/consoleFull)
for PR 2344 at commit
[`413f946`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55870259
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20463/consoleFull)
for PR 2344 at commit
[`413f946`](https://github.com/ap
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55222163
Ha, first pass in recent days!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55123057
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20103/consoleFull)
for PR 2344 at commit
[`ce576b3`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2344#issuecomment-55110094
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20103/consoleFull)
for PR 2344 at commit
[`ce576b3`](https://github.com/ap
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/2344
[SPARK-3407][SQL]Add Date type support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adrian-wang/spark date
Alternatively you can review
99 matches
Mail list logo
