Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5940#discussion_r29950898
--- Diff: .rat-excludes ---
@@ -74,5 +74,12 @@ logs
.*scalastyle-output.xml
.*dependency-reduced-pom.xml
known_translations
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5940#discussion_r29950862
--- Diff: .rat-excludes ---
@@ -74,5 +74,12 @@ logs
.*scalastyle-output.xml
.*dependency-reduced-pom.xml
known_translations
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5940
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5940#issuecomment-100280522
thanks @pwendell !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/5940#issuecomment-100279143
Okay verified the filenames are fixed. Going to pull this in now since it's
way past the feature deadline.
---
If your project is set up for it, you can reply to this
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-99463126
@scwf @rxin oh, sorry about the file name issue, that is really
unfortunate. I thought it was a limited enough set of URLs it worked out ok,
didn't realize the windows
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4435
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-99289103
hmmm we might need to revert this for that and fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-99293798
@squito I'm going to revert the patch. Let's figure out how to deal with
the file names properly. URLs are not proper filenames.
On top of that, is there any reason
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-99286066
+1 to rename the test files, since you added test file which names contain
?/ , this leads to git pull failure:
```
$ git pull origin master
From
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29656230
--- Diff:
core/src/main/java/org/apache/spark/status/api/v1/TaskSorting.java ---
@@ -0,0 +1,45 @@
+package org.apache.spark.status.api.v1;/*
+ *
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29656282
--- Diff: core/src/main/java/org/apache/spark/JobExecutionStatus.java ---
@@ -17,9 +17,15 @@
package org.apache.spark;
+import
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29656312
--- Diff:
core/src/main/java/org/apache/spark/status/api/v1/StageStatus.java ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29656304
--- Diff:
core/src/main/java/org/apache/spark/status/api/v1/ApplicationStatus.java ---
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-99017279
Hey Imran - I had a few comments about enums I'm not sure whether we want
to annotate private (I'll leave it to to you based on your intentions). Overall
LGTM, feel
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-99029393
Those enums were meant to be public -- they are part of the returned value
from some endpoints, so we want them included in the mima checks (just like all
the new pojos
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29658278
--- Diff: docs/monitoring.md ---
@@ -174,6 +174,80 @@ making it easy to identify slow tasks, data skew, etc.
Note that the history server only
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-99230344
I think Github is confused about the test files added in this pull request
and now thinks 30% of Spark is written in PHP.
Can we rename the files or somehow making
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29594361
--- Diff: core/src/main/java/org/apache/spark/util/EnumUtil.java ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29594683
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98902940
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98902949
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29640742
--- Diff: docs/monitoring.md ---
@@ -174,6 +174,79 @@ making it easy to identify slow tasks, data skew, etc.
Note that the history server only
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98915531
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98909291
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98941726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98941689
[Test build #31814 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31814/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98941723
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98942717
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98942719
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98942692
[Test build #31816 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31816/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98903063
[Test build #31814 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31814/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98916119
[Test build #31818 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31818/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98915490
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98909545
Hi @pwendell , I added a section to the monitoring docs on this, including
a list of endpoints. It also includes a section on the guarantees of
versioning (it might be
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98909492
[Test build #31816 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31816/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98944480
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98944476
[Test build #31818 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31818/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98944481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98909284
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98446030
@squito - I think if Marcello took a good pass then we can probably pull
this one in. I will try to look at it by or on Monday as well just to get
another pair of eyes
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29559782
--- Diff:
core/src/main/java/org/apache/spark/status/api/v1/TaskSorting.java ---
@@ -0,0 +1,45 @@
+package org.apache.spark.status.api.v1;/*
+ *
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98537052
Hey @squito - I took just a pretty quick look. However two things did jump
out as questions:
1. At first glance, I don't see any way for users to discover this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98253387
[Test build #31614 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31614/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98253349
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98264041
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98252840
[Test build #31595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31595/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98252876
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98264040
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98264030
[Test build #31614 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31614/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98252881
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-9825
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98219968
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98219997
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98220037
[Test build #31595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31595/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98190560
[Test build #31579 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31579/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98188177
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98188066
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98188174
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98190196
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98188171
[Test build #31578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31578/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98188154
[Test build #31578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31578/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98188053
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98190217
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98210909
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98210897
[Test build #31579 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31579/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98210910
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-98016466
ping @JoshRosen @pwendell . any chance of this making it in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97192934
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97271246
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97271247
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97245702
Lemme summarize what I've addressed:
* I changed the way jersey uses jackson to clean up the dependencies. It
leads to a setup that doesn't fit the standard
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97271241
[Test build #31183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31183/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97117811
[Test build #31143 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31143/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97122807
[Test build #31143 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31143/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97127280
[Test build #31145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31145/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97135395
[Test build #31145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31145/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97202002
[Test build #31170 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31170/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97201677
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97201705
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97210641
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97210644
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97210626
[Test build #31170 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31170/consoleFull)
for PR 4435 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29289049
--- Diff:
core/src/main/java/org/apache/spark/status/api/v1/TaskSorting.java ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97211205
The code LGTM, just a few small nits remaining. Tests are failing because
of MiMA having trouble finding jax-rs classes; I wonder if an explicit
dependency needs to be
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97244308
[Test build #31183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31183/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97244072
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97244091
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4435#discussion_r29288867
--- Diff:
core/src/main/java/org/apache/spark/status/api/v1/TaskSorting.java ---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97172256
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97172225
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97172540
[Test build #31154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31154/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97182960
[Test build #31154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31154/consoleFull)
for PR 4435 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97182983
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-97182979
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-96889021
[Test build #31098 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31098/consoleFull)
for PR 4435 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4435#issuecomment-96873940
[Test build #31098 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31098/consoleFull)
for PR 4435 at commit
97 matches
Mail list logo
