Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r30820880
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +406,81 @@ private[spark] class
Github user javabrett commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r30769030
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +406,81 @@ private[spark] class
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-58197006
Thanks @andrewor14. I've merged this into 1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2577
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18459132
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +405,82 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18459205
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +405,82 @@ private[spark] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-58026499
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21330/consoleFull)
for PR 2577 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-58037924
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21330/consoleFull)
for PR 2577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-58037937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-58136343
LGTM, feel free to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18395371
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -328,10 +348,18 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18395494
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -328,10 +348,18 @@ private[spark] class
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57807019
Addressed all the review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57807655
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21248/consoleFull)
for PR 2577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57808155
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57808148
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21248/consoleFull)
for PR 2577 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57809815
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21250/consoleFull)
for PR 2577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57818940
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57818934
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21250/consoleFull)
for PR 2577 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18418163
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -231,33 +259,26 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18418213
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -328,10 +349,18 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18418362
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +405,82 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18418613
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +405,82 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18418623
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +405,82 @@ private[spark] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57857279
Hey @tgravescs this LGTM pending a few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57313993
thanks for the review @vanzin. I've updated it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57314584
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21040/consoleFull)
for PR 2577 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57325361
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21040/consoleFull)
for PR 2577 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57325372
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57347769
LGTM. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18238499
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClientImpl.scala
---
@@ -66,14 +70,16 @@ private class YarnRMClientImpl(args:
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18238788
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClientImpl.scala
---
@@ -66,14 +70,16 @@ private class YarnRMClientImpl(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18238861
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -450,6 +511,15 @@ object ApplicationMaster extends
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18239431
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +404,80 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18239465
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +404,80 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18239726
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,108 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18239755
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +404,80 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18240067
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +404,80 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18240121
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +404,80 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18240375
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -343,6 +371,11 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18240353
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -328,10 +348,18 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18240426
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -231,33 +258,26 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18243513
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,108 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18243719
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -328,10 +348,18 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18248626
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,108 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18249133
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -328,10 +348,18 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18249218
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +404,80 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18251599
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +404,80 @@ private[spark] class
GitHub user tgravescs opened a pull request:
https://github.com/apache/spark/pull/2577
[SPARK-3627] - [yarn] - fix exit code and final status reporting to RM
See the description and whats handled in the jira comment:
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57176392
@witgo can you verify this covers https://github.com/apache/spark/pull/2311
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57176963
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20975/consoleFull)
for PR 2577 at commit
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57185274
also note this does change everything to allow yarn to retry. previously
when it hit the maximum number of executor failures it didn't retry the AM. I
waffled back
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57187881
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57187866
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20975/consoleFull)
for PR 2577 at commit
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18170801
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -450,6 +539,15 @@ object ApplicationMaster extends Logging {
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18173150
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -450,6 +539,15 @@ object ApplicationMaster extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18174075
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18174328
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18174440
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -232,32 +285,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18174477
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18174148
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18174887
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -383,40 +432,80 @@ private[spark] class
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2577#issuecomment-57209937
Looks ok to me, although the exception handling does feel a little
paranoid. :-) Just had a few nits.
---
If your project is set up for it, you can reply to this email
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18179848
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18180627
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18180991
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18181156
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18182939
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2577#discussion_r18183146
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -71,80 +74,134 @@ private[spark] class
69 matches
Mail list logo
