Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2543
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-67374340
Sorry for the delay merging this, but I have been concerned that we are
adding unnecessary complexity to analysis by adding more types of expressions.
I've built a simp
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-60737418
Hi @marmbrus @liancheng, I think it's better to calculate the `ordinal` of
`GetField` in analyze phase, and I have updated the code to introduce the
`UnresolvedGetField
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-59674040
Ping @marmbrus @liancheng I have finished the code locally, if you vote
for `UnresolvedGetField`, I can push the code immediately.
---
If your project is set up for
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-58600998
@marmbrus As commented before, I think we should handle `GetItem` and
`GetField` differently even they are very similar. For `GetItem`, we need
calculate the `ordinal`
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18564336
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -118,6 +120,19 @@ class Analyzer(catalog: Catalog, regis
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18316116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -118,6 +120,19 @@ class Analyzer(catalog: Catalog, regist
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18315705
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -50,6 +50,8 @@ class Analyzer(catalog: Catalog, registry:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18315648
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,7 +73,9 @@ case class GetItem(child: Expressio
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-57556348
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/241/consoleFull)
for PR 2543 at commit
[`c5b9106`](https://github.com/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-57552822
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/241/consoleFull)
for PR 2543 at commit
[`c5b9106`](https://github.com/a
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-57110457
Hi @marmbrus , I have updated my PR according to your comments. Do you mind
review it again?
---
If your project is set up for it, you can reply to this email and have
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18127069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,31 +75,35 @@ case class GetItem(child: Expres
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18127040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -366,7 +366,7 @@ class SqlParser extends StandardTokenParsers wit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18126983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,31 +75,35 @@ case class GetItem(child: Expres
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2543#issuecomment-57062687
Thanks for working on this! A few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125297
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,31 +75,35 @@ case class GetItem(child: Express
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -118,6 +119,19 @@ class Analyzer(catalog: Catalog, regist
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -366,7 +366,7 @@ class SqlParser extends StandardTokenParsers with
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2543#discussion_r18125290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -73,31 +75,35 @@ case class GetItem(child: Express
20 matches
Mail list logo
