Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2871
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2871#issuecomment-60792272
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2871#issuecomment-60792256
[Test build #22362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22362/consoleFull)
for PR 2871 at commit
[`1456d65`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2871#issuecomment-60778288
[Test build #22362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22362/consoleFull)
for PR 2871 at commit
[`1456d65`](https://githu
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/2871#issuecomment-60778158
Thanks @rxin and @JoshRosen for taking a look. I will merge after Jenkins
passes
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19480010
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -157,14 +161,12 @@ private[spark] class TorrentBroadcast[T:
ClassTag]
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19479577
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -173,15 +175,21 @@ private[spark] class TorrentBroadcast[T:
ClassTag]
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19479618
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -173,15 +175,21 @@ private[spark] class TorrentBroadcast[T:
ClassTag]
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2871#issuecomment-60716720
LGTM, too. Very clever testing strategy!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19455404
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -157,14 +161,12 @@ private[spark] class TorrentBroadcast[T:
ClassTag
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19455293
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -173,15 +175,21 @@ private[spark] class TorrentBroadcast[T:
ClassTag](obj
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19455263
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -173,15 +175,21 @@ private[spark] class TorrentBroadcast[T:
ClassTag
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19455214
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -173,15 +175,21 @@ private[spark] class TorrentBroadcast[T:
ClassTag
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2871#issuecomment-60715459
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19455067
--- Diff:
core/src/test/scala/org/apache/spark/broadcast/BroadcastSuite.scala ---
@@ -21,11 +21,28 @@ import scala.util.Random
import org.scalatest.{A
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2871#discussion_r19455054
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -173,15 +175,21 @@ private[spark] class TorrentBroadcast[T:
ClassTag](obj
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2871#issuecomment-60714605
[Test build #22335 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22335/consoleFull)
for PR 2871 at commit
[`d6c5ee9`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2871#issuecomment-60714608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22
18 matches
Mail list logo