[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2015-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2015-02-26 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3425#issuecomment-76282209 Mind closing this PR? I'm not seeing a clear argument for changing this given the tradeoffs, and that Python examples don't use 127.0.0.1. --- If your project is set up f

[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2015-02-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3425#issuecomment-75435434 I suggest closing this unless we can point to a clear reason to prefer `127.0.0.1`. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2015-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3425#issuecomment-73737787 What was the outcome here? I can't claim to be an expert, but, obviously `localhost` is a symbolic name and that's generally the right thing to use to mean "the local mach

[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2014-11-24 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3425#issuecomment-64312914 @lvsoft I agreed that 127.0.0.1 is better than localhost in some cases, if it will not work in the case of the machines only have IPv6, which happens in Facebook.

[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2014-11-24 Thread lvsoft
Github user lvsoft commented on the pull request: https://github.com/apache/spark/pull/3425#issuecomment-64308603 I did a doctest in aggregation.py to confirm this fix is OK if ```localhost``` can not be resolved. However, I'm not fully confident that spark will work well totally in s

[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2014-11-24 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3425#issuecomment-64256243 @lvsoft There are many cases that will fail if `localhost` can not be resolved. Does spark work totally well after this fix (such as webui)? --- If your project is set u

[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2014-11-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3425#issuecomment-64164013 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-4475] change "localhost" to "127.0.0.1"...

2014-11-24 Thread lvsoft
GitHub user lvsoft opened a pull request: https://github.com/apache/spark/pull/3425 [SPARK-4475] change "localhost" to "127.0.0.1" if "localhost" can't be resolved This will fix [SPARK-4475] Simply change "localhost" to equivalent "127.0.0.1" will solve the issue. You can