Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63777328
@manishamde @jkbradley Thanks! Merged into master and branch-1.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63774234
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63774229
[Test build #23663 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23663/consoleFull)
for PR 3374 at commit
[`7097251`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63771207
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63771201
[Test build #23662 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23662/consoleFull)
for PR 3374 at commit
[`98dea09`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63767980
[Test build #23663 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23663/consoleFull)
for PR 3374 at commit
[`7097251`](https://githu
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629856
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -40,151 +39,98 @@ import org.apache.spark.storage.StorageLevel
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629859
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -40,151 +39,98 @@ import org.apache.spark.storage.StorageLevel
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629860
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/treeEnsembleModels.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Softwar
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629858
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala ---
@@ -387,7 +386,7 @@ object RandomForest extends Serializable with Logging {
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63766642
@mengxr Thanks for the updates! Just added a few small comments. Other
than those, LGTM
---
If your project is set up for it, you can reply to this email and have yo
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629451
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -40,151 +39,98 @@ import org.apache.spark.storage.StorageLevel
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629452
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/treeEnsembleModels.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Soft
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629126
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/RandomForest.scala ---
@@ -387,7 +386,7 @@ object RandomForest extends Serializable with Logging
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629031
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -40,151 +39,98 @@ import org.apache.spark.storage.StorageLevel
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20629011
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -40,151 +39,98 @@ import org.apache.spark.storage.StorageLevel
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20628996
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -45,146 +43,92 @@ import org.apache.spark.storage.StorageLevel
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63765215
[Test build #23662 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23662/consoleFull)
for PR 3374 at commit
[`98dea09`](https://githu
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20628796
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -45,146 +43,92 @@ import org.apache.spark.storage.StorageLevel
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63763093
Completed my pass. LGTM! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20627362
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/GradientBoostedTreesSuite.scala
---
@@ -23,104 +23,95 @@ import org.apache.spark.mllib.regression.L
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20624623
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/GradientBoostedTreesSuite.scala
---
@@ -23,104 +23,95 @@ import org.apache.spark.mllib.regressi
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20623750
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/GradientBoostedTreesSuite.scala
---
@@ -23,104 +23,95 @@ import org.apache.spark.mllib.regressi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63750642
[Test build #23643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23643/consoleFull)
for PR 3374 at commit
[`4aae3b7`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63750651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20623463
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/TreeEnsembleModel.scala
---
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Soft
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20622816
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/TreeEnsembleModel.scala
---
@@ -0,0 +1,182 @@
+/*
--- End diff --
Should
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20622629
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -45,146 +43,92 @@ import org.apache.spark.storage.StorageLevel
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20622307
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -45,146 +43,92 @@ import org.apache.spark.storage.StorageLevel
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63746922
Should the```trainClassifier``` and ``trainRegressor`` methods from
```DecisionTree``` and ```RandomForest``` classes also be the deprecated?
---
If your project is s
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63744889
@mengxr The plan to move to mllib.ensemble namespace with a new class
sounds good to me.
---
If your project is set up for it, you can reply to this email and have yo
Github user manishamde commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20621257
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/GradientBoostedTrees.scala ---
@@ -45,146 +43,92 @@ import org.apache.spark.storage.StorageLevel
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63744703
@manishamde The current impl is attached to trees. Even if we rename it
back to `GradientBoosting`. it has to live under `mllib.tree` instead of
`mllib.ensemble`. When we
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63744101
Will we have to rename ```GradientBoostedTrees``` back to
```GradientBoosting``` when we add generic weak learner support? I think we
should not modify the name of the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3374#issuecomment-63742362
[Test build #23643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23643/consoleFull)
for PR 3374 at commit
[`4aae3b7`](https://githu
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3374#discussion_r20620079
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/GradientBoostedTreesSuite.scala
---
@@ -23,104 +23,95 @@ import org.apache.spark.mllib.regression.L
GitHub user mengxr opened a pull request:
https://github.com/apache/spark/pull/3374
[SPARK-4486][MLLIB] Improve GradientBoosting APIs and doc
There are some inconsistencies in the gradient boosting APIs. The target is
a general boosting meta-algorithm, but the implementation is atta
38 matches
Mail list logo
