Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64512596
LGTM. Merged into master and branch-1.2. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64510862
[Test build #23862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23862/consoleFull)
for PR 3439 at commit
[`cfec17e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64510867
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64508134
[Test build #23854 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23854/consoleFull)
for PR 3439 at commit
[`ed5da2c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64508136
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64504744
[Test build #23862 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23862/consoleFull)
for PR 3439 at commit
[`cfec17e`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64502745
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64502742
[Test build #23856 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23856/consoleFull)
for PR 3439 at commit
[`a27eb6d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64502623
[Test build #23856 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23856/consoleFull)
for PR 3439 at commit
[`a27eb6d`](https://githu
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64502217
Updated LogLoss.
@mengxr @manishamde Thanks for looking at this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3439#discussion_r20911009
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -45,19 +46,21 @@ object LogLoss extends Loss {
model: TreeEn
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64501800
[Test build #23854 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23854/consoleFull)
for PR 3439 at commit
[`ed5da2c`](https://githu
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3439#discussion_r20910282
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -45,19 +46,21 @@ object LogLoss extends Loss {
model: TreeEn
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64498949
@jkbradley LGTM. Thanks for the documentation too -- it is really helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3439#discussion_r20909144
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -45,19 +46,21 @@ object LogLoss extends Loss {
model: TreeEnsem
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64497207
@jkbradley I am trying to find my reference for the LogLoss calculations.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64486875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64486870
[Test build #23849 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23849/consoleFull)
for PR 3439 at commit
[`5e52bff`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64474620
[Test build #23849 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23849/consoleFull)
for PR 3439 at commit
[`5e52bff`](https://githu
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64474382
I just pushed an update which includes:
* removing the 1/2 from SquaredError. This also required updating the test
suite since it effectively doubles the gradient a
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3439#discussion_r20885397
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/SquaredError.scala ---
@@ -49,18 +48,17 @@ object SquaredError extends Loss {
}
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/3439#discussion_r20853259
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/SquaredError.scala ---
@@ -49,18 +48,17 @@ object SquaredError extends Loss {
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64306124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64306120
[Test build #23811 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23811/consoleFull)
for PR 3439 at commit
[`7c38962`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3439#issuecomment-64300547
[Test build #23811 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23811/consoleFull)
for PR 3439 at commit
[`7c38962`](https://githu
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/3439
[SPARK-4583] [mllib] LogLoss for GradientBoostedTrees fix + doc updates
Currently, the LogLoss used by GradientBoostedTrees has 2 issues:
* the gradient (and therefore loss) does not match that
27 matches
Mail list logo
