Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3443
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-65316695
Thanks for fixing this! I've merged to master and 1.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-65194684
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-65194676
[Test build #24030 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24030/consoleFull)
for PR 3443 at commit
[`2e98677`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-65190341
[Test build #24030 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24030/consoleFull)
for PR 3443 at commit
[`2e98677`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-65177298
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-65177296
[Test build #24018 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24018/consoleFull)
for PR 3443 at commit
[`36236a5`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-65176683
[Test build #24018 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24018/consoleFull)
for PR 3443 at commit
[`36236a5`](https://githu
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-65136744
Can you add some test cases to the `ExpressionEvaluationSuite`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64780940
[Test build #23922 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23922/consoleFull)
for PR 3443 at commit
[`6f5716f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64780948
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64773793
[Test build #23922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23922/consoleFull)
for PR 3443 at commit
[`6f5716f`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64769384
[Test build #23920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23920/consoleFull)
for PR 3443 at commit
[`cee92bd`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64769394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64762157
[Test build #23920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23920/consoleFull)
for PR 3443 at commit
[`cee92bd`](https://githu
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3443#discussion_r20976923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -106,12 +106,17 @@ case class Multiply(left: Expressio
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64512466
[Test build #23867 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23867/consoleFull)
for PR 3443 at commit
[`22ecd9a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64512469
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64508417
[Test build #23867 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23867/consoleFull)
for PR 3443 at commit
[`22ecd9a`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64507365
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64507361
[Test build #23865 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23865/consoleFull)
for PR 3443 at commit
[`cf28c58`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64507278
[Test build #23865 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23865/consoleFull)
for PR 3443 at commit
[`cf28c58`](https://githu
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64507179
@ueshin Thanks for your reminding, I made a mistake here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64430796
What do you think about `IntegralType`?
Currently I think it throws `ArithmeticException` when the divider is `0`.
---
If your project is set up for it, you can reply
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64430073
`Divide.nullable` should be `true` if it returns `null` when the divider is
`0`.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3443#discussion_r20874507
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -142,6 +142,8 @@ abstract class Expression extends Tre
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64323521
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64323518
[Test build #23821 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23821/consoleFull)
for PR 3443 at commit
[`2dfe50f`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3443#issuecomment-64318454
[Test build #23821 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23821/consoleFull)
for PR 3443 at commit
[`2dfe50f`](https://githu
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/3443
[SPARK-4593] [SQL] return null when divider is 0 of Double type
SELECT max(1/0) FROM src
would return a very large number, which is obviously not right.
For hive-0.12, hive would return `
30 matches
Mail list logo
