Github user varunsaxena commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-68760841
Thanks for the review and commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-68752703
Thanks. I'm merging this in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-68464184
[Test build #24963 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24963/consoleFull)
for PR 3562 at commit
[`6e97f72`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-68464188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-68458773
[Test build #24963 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24963/consoleFull)
for PR 3562 at commit
[`6e97f72`](https://githu
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-68458684
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-68403694
ping @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user varunsaxena commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-67061747
@rxin , any conclusion on this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user varunsaxena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21361036
--- Diff: docs/configuration.md ---
@@ -777,6 +777,16 @@ Apart from these, the following properties are also
available, and may be useful
Github user varunsaxena commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-65761296
@rxin , I will just summarize what are the configuration defaults I have
used. I put a value of 100 in initial pull request with the intention of having
a futher disc
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21359356
--- Diff: docs/configuration.md ---
@@ -777,6 +777,16 @@ Apart from these, the following properties are also
available, and may be useful
Github user varunsaxena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21357610
--- Diff: docs/configuration.md ---
@@ -777,6 +777,16 @@ Apart from these, the following properties are also
available, and may be useful
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21347900
--- Diff:
core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala ---
@@ -81,7 +81,8 @@ private[nio] class ConnectionManager(
private val
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21347868
--- Diff: docs/configuration.md ---
@@ -777,6 +777,16 @@ Apart from these, the following properties are also
available, and may be useful
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21347856
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -37,7 +37,9 @@ public boolean preferDirectBufs() {
/
Github user varunsaxena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21216817
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -53,7 +53,9 @@ class BlockManagerMasterActor(val isLocal: Bool
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21218170
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -53,7 +53,9 @@ class BlockManagerMasterActor(val isLocal: Boolean, co
Github user varunsaxena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21216319
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -37,7 +37,8 @@ public boolean preferDirectBufs() {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21214929
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -37,7 +37,8 @@ public boolean preferDirectBufs() {
/
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21214939
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -53,7 +53,9 @@ class BlockManagerMasterActor(val isLocal: Boolean, co
Github user varunsaxena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21214791
--- Diff:
core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala ---
@@ -81,7 +81,8 @@ private[nio] class ConnectionManager(
priv
Github user Lewuathe commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21203749
--- Diff:
core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala ---
@@ -81,7 +81,8 @@ private[nio] class ConnectionManager(
private
Github user varunsaxena commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-65320054
Made the changes as per review. Also updated configuration.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user varunsaxena commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21197916
--- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
@@ -65,7 +65,8 @@ private[spark] object AkkaUtils extends Logging {
Github user varunsaxena commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-65316168
Wanted to know what should be the default spark.network.timeout value ? I
have kept it at 100 sec. Should it be different ?
---
If your project is set up for it, you
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21196648
--- Diff:
core/src/main/scala/org/apache/spark/network/nio/ConnectionManager.scala ---
@@ -81,7 +81,8 @@ private[nio] class ConnectionManager(
private val
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21196604
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -53,7 +53,9 @@ class BlockManagerMasterActor(val isLocal: Boolean, co
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21196524
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -37,7 +37,8 @@ public boolean preferDirectBufs() {
/
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3562#discussion_r21196545
--- Diff: core/src/main/scala/org/apache/spark/util/AkkaUtils.scala ---
@@ -65,7 +65,8 @@ private[spark] object AkkaUtils extends Logging {
val akk
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3562#issuecomment-65314923
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user varunsaxena opened a pull request:
https://github.com/apache/spark/pull/3562
[SPARK-4688] Have a single shared network timeout in Spark
[SPARK-4688] Have a single shared network timeout in Spark
You can merge this pull request into a Git repository by running:
$ git
32 matches
Mail list logo
