Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4029#discussion_r23975285
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -32,6 +32,7 @@ import org.apache.spark.executor._
import org.apache.spark.
Github user nightwolfzor commented on a diff in the pull request:
https://github.com/apache/spark/pull/4029#discussion_r23975204
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -32,6 +32,7 @@ import org.apache.spark.executor._
import org.apache.spa
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4029#discussion_r23972545
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -32,6 +32,7 @@ import org.apache.spark.executor._
import org.apache.spark.
Github user nightwolfzor commented on a diff in the pull request:
https://github.com/apache/spark/pull/4029#discussion_r23972387
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -32,6 +32,7 @@ import org.apache.spark.executor._
import org.apache.spa
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70296266
@JoshRosen that could work. If we do decide to do it we must absolutely
make sure that we don't break anything for 1.2.0 users, since compatibility in
a patch release
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4029
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70295103
If the only backwards incompatibility is via pattern matching on listener
events, can we maybe just make the new field a mutable var that's set outside
of the construct
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70294815
The changes here actually LGTM, so I will merge this in master. Thanks
@sarutak!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70294228
@sarutak @JoshRosen I would prefer to use the same solution for both master
and 1.2 if possible, so if something goes wrong we only need to reason about
one fix. Since
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70202568
[Test build #25627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25627/consoleFull)
for PR 4029 at commit
[`0af9e22`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70202575
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70198045
[Test build #25627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25627/consoleFull)
for PR 4029 at commit
[`0af9e22`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70006879
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-70006871
[Test build #25569 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25569/consoleFull)
for PR 4029 at commit
[`da8bd14`](https://gith
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69996037
@JoshRosen Thanks for your advises. I reflected your comment and added a
test case.
For now, I will take the original approach and also, I will try to address
this is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69996068
[Test build #25569 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25569/consoleFull)
for PR 4029 at commit
[`da8bd14`](https://githu
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4029#discussion_r22963720
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -469,6 +471,7 @@ private[spark] object JsonProtocol {
def jobStart
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4029#discussion_r22963608
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -469,6 +471,7 @@ private[spark] object JsonProtocol {
def jobStart
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4029#discussion_r22963362
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -58,6 +58,7 @@ case class SparkListenerTaskEnd(
@DeveloperApi
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69976817
This is a nice patch, but I wonder whether there's a smaller fix that
doesn't require changing SparkListener events; that will make it easier to
backport that patch to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69890446
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69890439
[Test build #25527 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25527/consoleFull)
for PR 4029 at commit
[`26b9b99`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69882945
[Test build #25527 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25527/consoleFull)
for PR 4029 at commit
[`26b9b99`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69879699
[Test build #25516 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25516/consoleFull)
for PR 4029 at commit
[`2d47bd3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69879709
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69876282
[Test build #25516 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25516/consoleFull)
for PR 4029 at commit
[`2d47bd3`](https://githu
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69876213
Thanks, I just did `assembly`.
Now the compilation error is resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69865400
It looks like this failed due to a test compilation error:
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/core/src/test/scala/org/apache/spark/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69851119
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69851116
[Test build #25490 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25490/consoleFull)
for PR 4029 at commit
[`11107a8`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4029#issuecomment-69847914
[Test build #25490 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25490/consoleFull)
for PR 4029 at commit
[`11107a8`](https://githu
GitHub user sarutak opened a pull request:
https://github.com/apache/spark/pull/4029
[SPARK-5231][WebUI] History Server shows wrong job submission time.
History Server doesn't show collect job submission time.
It's because `JobProgressListener` updates job submission time every t
32 matches
Mail list logo
