Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75967598
If my comment is the only thing that was holding this PR from merging, I
withdraw my comment. :)
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user prabeesh commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75948873
@srowen I think so I addressed the @dragos comments. Should we need more
updates for that comments ?, If so could you please explain in detail ?
---
If your project
Github user prabeesh commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75968545
@dragos no need of withdraw the comment.
Ultimately my aim to deliver good code to Spark users.
---
If your project is set up for it, you can reply to this email
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75948201
@prabeesh eh OK you mean you addressed that comment? I still am not sure
that the comment from @dragos was addressed as I mentioned before. But since
that `catch` block
Github user prabeesh commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75947077
@srowen warning that what is occurring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75841169
[Test build #27899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27899/consoleFull)
for PR 4178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75841181
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75824150
[Test build #27897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27897/consoleFull)
for PR 4178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75824362
[Test build #27897 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27897/consoleFull)
for PR 4178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75824366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75826159
[Test build #27899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27899/consoleFull)
for PR 4178 at commit
Github user prabeesh commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-74553655
@srowen is there any more updates here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-74555104
@prabeesh this looks like it's waiting on a change to address the comment
from @dragos - no need to catch and log the exception - and to the issue of
infinite looping if
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73744002
[Test build #27215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27215/consoleFull)
for PR 4178 at commit
Github user prabeesh commented on a diff in the pull request:
https://github.com/apache/spark/pull/4178#discussion_r24431522
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/MQTTWordCount.scala
---
@@ -42,25 +40,33 @@ object MQTTPublisher {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4178#discussion_r24432610
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/MQTTWordCount.scala
---
@@ -42,25 +40,33 @@ object MQTTPublisher {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73749493
[Test build #27217 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27217/consoleFull)
for PR 4178 at commit
Github user prabeesh commented on a diff in the pull request:
https://github.com/apache/spark/pull/4178#discussion_r24433999
--- Diff:
external/mqtt/src/main/scala/org/apache/spark/streaming/mqtt/MQTTInputDStream.scala
---
@@ -17,23 +17,23 @@
package
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73748645
[Test build #27216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27216/consoleFull)
for PR 4178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73765570
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73765549
[Test build #27217 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27217/consoleFull)
for PR 4178 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4178#discussion_r24438621
--- Diff:
external/mqtt/src/main/scala/org/apache/spark/streaming/mqtt/MQTTInputDStream.scala
---
@@ -17,23 +17,23 @@
package
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73762953
[Test build #27216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27216/consoleFull)
for PR 4178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73762964
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73758129
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73758115
[Test build #27215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27215/consoleFull)
for PR 4178 at commit
Github user prabeesh commented on a diff in the pull request:
https://github.com/apache/spark/pull/4178#discussion_r24352985
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/MQTTWordCount.scala
---
@@ -42,25 +40,33 @@ object MQTTPublisher {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73570181
[Test build #27120 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27120/consoleFull)
for PR 4178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73575314
[Test build #27115 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27115/consoleFull)
for PR 4178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73575327
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73579905
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73579892
[Test build #27116 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27116/consoleFull)
for PR 4178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73581863
[Test build #27118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27118/consoleFull)
for PR 4178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73581874
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/4178#discussion_r24359960
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/MQTTWordCount.scala
---
@@ -42,25 +40,33 @@ object MQTTPublisher {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73563621
[Test build #27113 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27113/consoleFull)
for PR 4178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73564510
[Test build #27115 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27115/consoleFull)
for PR 4178 at commit
Github user prabeesh commented on a diff in the pull request:
https://github.com/apache/spark/pull/4178#discussion_r24353169
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/MQTTWordCount.scala
---
@@ -42,25 +40,33 @@ object MQTTPublisher {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73566346
[Test build #27116 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27116/consoleFull)
for PR 4178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73583034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73583023
[Test build #27120 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27120/consoleFull)
for PR 4178 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73485167
This is just waiting on response to my comments. most of it is that some of
the import movements put imports in the wrong place now. (Some are correct
changes though.)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73568240
[Test build #27118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27118/consoleFull)
for PR 4178 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73576408
[Test build #27113 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27113/consoleFull)
for PR 4178 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-73576418
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
46 matches
Mail list logo
