[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76503823 Cool, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76499219 @andrewor14 I just merged it to master and branch-1.3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4758 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76456876 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76456868 [Test build #28077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28077/consoleFull) for PR 4758 at commit [`252fa0f`](https://gith

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76444830 Updated, you can merge it after Jenkins nods :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76444880 [Test build #28077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28077/consoleFull) for PR 4758 at commit [`252fa0f`](https://githu

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-27 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4758#discussion_r25526262 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -315,7 +315,14 @@ abstract class

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-26 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4758#discussion_r25485273 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -315,7 +315,14 @@ abstract clas

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-26 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/4758#discussion_r25479512 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -315,7 +315,14 @@ abstract

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-26 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4758#discussion_r25469585 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -315,7 +315,14 @@ abstract clas

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-26 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76284574 I said I was going to merge this, but instead I left one more comment inline. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-26 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-76284089 I'm going to merge this with @chenghao-intel's suggestion. Thanks everyone. This is going into master 1.3 --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-26 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4758#discussion_r25414445 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -315,7 +315,14 @@ abstract class

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-75909369 [Test build #27935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27935/consoleFull) for PR 4758 at commit [`1b3d1e3`](https://gith

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-75909373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-24 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/4758#discussion_r25318071 --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala --- @@ -315,7 +315,14 @@ abstract

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4758#issuecomment-75904355 [Test build #27935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27935/consoleFull) for PR 4758 at commit [`1b3d1e3`](https://githu

[GitHub] spark pull request: [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PI...

2015-02-24 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/4758 [SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PID_DIR when running Thrift server test suites This is a follow-up of #4720. By default, `spark-daemon.sh` writes PID files under `/tmp`, which makes i