Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24766338
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -88,12 +88,12 @@ private[sql] class DataFrameImpl protected[sql](
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24748159
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -39,13 +39,14 @@ class GroupedData protected[sql](df: DataFrameImpl,
groupingEx
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74493864
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74493853
[Test build #27549 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27549/consoleFull)
for PR 4592 at commit
[`9446896`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74480130
[Test build #27549 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27549/consoleFull)
for PR 4592 at commit
[`9446896`](https://githu
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24731797
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -39,13 +39,14 @@ class GroupedData protected[sql](df: DataFrameImpl,
groupingExpr
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24731788
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -39,13 +39,14 @@ class GroupedData protected[sql](df: DataFrameImpl,
groupingExpr
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24731783
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -39,13 +39,14 @@ class GroupedData protected[sql](df: DataFrameImpl,
groupingExpr
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74425215
LGTMï¼ thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74418479
@rxin @davies these issues are addressed in new commits. Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74415013
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74415009
[Test build #27519 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27519/consoleFull)
for PR 4592 at commit
[`353fad7`](https://gith
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24720200
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -714,28 +726,28 @@ def count(self):
[Row(age=2, count=1), Row(age=5, count=1)]
"""
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24720235
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -664,6 +664,18 @@ def _api(self):
return _api
+def df_varargs_api(f, *args):
+
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24720234
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -664,6 +664,18 @@ def _api(self):
return _api
+def df_varargs_api(f, *args):
+
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24720621
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -664,6 +664,18 @@ def _api(self):
return _api
+def df_varargs_api(f, *args):
+
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74406088
[Test build #27504 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27504/consoleFull)
for PR 4592 at commit
[`b079e6b`](https://gith
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24720203
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -88,12 +88,24 @@ private[sql] class DataFrameImpl protected[sql](
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74404099
[Test build #27504 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27504/consoleFull)
for PR 4592 at commit
[`b079e6b`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74410977
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74412125
[Test build #27519 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27519/consoleFull)
for PR 4592 at commit
[`353fad7`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74410972
[Test build #27511 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27511/consoleFull)
for PR 4592 at commit
[`54ed0c4`](https://gith
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24719364
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -714,30 +714,45 @@ def count(self):
[Row(age=2, count=1), Row(age=5, count=1)]
"""
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74408838
[Test build #27511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27511/consoleFull)
for PR 4592 at commit
[`54ed0c4`](https://githu
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24719554
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -714,30 +714,45 @@ def count(self):
[Row(age=2, count=1), Row(age=5, count=1)]
"""
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24720617
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -88,12 +88,24 @@ private[sql] class DataFrameImpl protected[sql](
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74406090
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24716974
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -714,30 +714,45 @@ def count(self):
[Row(age=2, count=1), Row(age=5, count=1)]
"""
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74387281
[Test build #27491 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27491/consoleFull)
for PR 4592 at commit
[`880c2ac`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74387286
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74383474
[Test build #27491 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27491/consoleFull)
for PR 4592 at commit
[`880c2ac`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74380692
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74380690
[Test build #27488 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27488/consoleFull)
for PR 4592 at commit
[`4c63a01`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74380639
[Test build #27488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27488/consoleFull)
for PR 4592 at commit
[`4c63a01`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74373239
[Test build #27480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27480/consoleFull)
for PR 4592 at commit
[`b1a24fc`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74373241
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74371781
[Test build #27480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27480/consoleFull)
for PR 4592 at commit
[`b1a24fc`](https://githu
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713729
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -93,7 +93,14 @@ private[sql] class DataFrameImpl protected[sql](
q
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713647
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -93,7 +93,14 @@ private[sql] class DataFrameImpl protected[sql](
q
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713616
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -93,7 +93,14 @@ private[sql] class DataFrameImpl protected[sql](
que
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713599
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -93,7 +93,14 @@ private[sql] class DataFrameImpl protected[sql](
q
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713033
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -154,6 +154,18 @@ class DataFrameSuite extends QueryTest {
testData
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74365698
Thanks for working on this. I would like to actually put this into 1.3,
because it makes more sense than the current API. If you can make the changes I
suggested quickly, th
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74365750
[Test build #27479 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27479/consoleFull)
for PR 4592 at commit
[`27069c3`](https://gith
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713032
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -154,6 +154,18 @@ class DataFrameSuite extends QueryTest {
testData
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74364348
[Test build #27479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27479/consoleFull)
for PR 4592 at commit
[`27069c3`](https://githu
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713035
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameImpl.scala
---
@@ -93,7 +93,14 @@ private[sql] class DataFrameImpl protected[sql](
que
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74365752
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713028
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -46,6 +46,15 @@ class GroupedData protected[sql](df: DataFrameImpl,
groupingExprs
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24713040
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -154,6 +154,18 @@ class DataFrameSuite extends QueryTest {
testData
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24703110
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -149,28 +157,70 @@ class GroupedData protected[sql](df: DataFrameImpl,
groupingEx
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74292424
[Test build #27442 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27442/consoleFull)
for PR 4592 at commit
[`371a3f7`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74292435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4592#issuecomment-74280213
[Test build #27442 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27442/consoleFull)
for PR 4592 at commit
[`371a3f7`](https://githu
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/4592
[SPARK-5799][SQL] Compute aggregation function on specified numeric columns
Compute aggregation function on specified numeric columns. For example:
val df = Seq(("a", 1, 0, "b"), ("b", 2,
56 matches
Mail list logo
