Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5037
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-89164396
Great thanks @tdas @mengxr !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r27715247
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegressionW
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-89160576
@tdas Thanks for the reminder! LGTM. I've merged it into both master and
branch-1.3.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-89145346
@mengxr Shouldnt this be merged for 1.3.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user freeman-lab commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-86736605
Agreed @tdas ! Discussed with @mengxr offline today and I think we're
satisfied with this fix. Any additional suggestions, or extra tests?
I want to make the
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-85133430
BTW, I really think we should merge this soon for 1.3.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26520319
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegres
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26520257
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -114,7 +114,7 @@ abstract class StreamingLinearAlg
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26518965
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -114,7 +114,7 @@ abstract class StreamingLinearAlgorith
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26518380
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -114,7 +114,7 @@ abstract class StreamingLinearAlgorith
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26501033
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegressionW
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26500716
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegres
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26498742
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegressionW
Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26498476
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegres
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26477243
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegressionW
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26476904
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearAlgorithm.scala
---
@@ -114,7 +114,7 @@ abstract class StreamingLinearAlgorith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-81483026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-81483011
[Test build #28639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28639/consoleFull)
for PR 5037 at commit
[`3af953e`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5037#issuecomment-81455102
[Test build #28639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28639/consoleFull)
for PR 5037 at commit
[`3af953e`](https://githu
GitHub user freeman-lab opened a pull request:
https://github.com/apache/spark/pull/5037
[SPARK-6345][STREAMING][MLLIB] Fix for training with prediction
This patch fixes a reported bug causing model updates to not properly
propagate to model predictions during streaming regression.
21 matches
Mail list logo